Skip to content

Allow enc_bootloader on older clang #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Allow enc_bootloader on older clang #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions bootloaders/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
if (TARGET pico_mbedtls)
# older clang seem to have a segment overlap issue that confuses picotool
if (PICO_C_COMPILER_IS_CLANG AND CMAKE_C_COMPILER_VERSION VERSION_LESS "17.0.0")
message("Skipping encrypted bootloader example on LLVM/Clang version < 17; please use GCC or newer LLVM/Clang")
else()
add_subdirectory_exclude_platforms(encrypted host rp2040 rp2350-riscv)
endif()
add_subdirectory_exclude_platforms(encrypted host rp2040 rp2350-riscv)
else()
# Assume picotool has no signing support, if no pico_mbedtls available
message("Skipping encrypted bootloader example as pico_mbedtls unavailable")
Expand Down
2 changes: 0 additions & 2 deletions bootloaders/encrypted/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ target_link_libraries(enc_bootloader pico_stdlib pico_rand pico_mbedtls)
# use stack guards, as AES variables are written near the stack
target_compile_definitions(enc_bootloader PRIVATE PICO_USE_STACK_GUARDS=1)

target_link_options(enc_bootloader PUBLIC -Wl,--print-memory-usage)

target_include_directories(enc_bootloader PRIVATE ${CMAKE_CURRENT_LIST_DIR})

# set as no_flash binary
Expand Down