Add Board Header Check Action #2519
Open
+117
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lurch
reviewed
Jun 12, 2025
|
Nice! 😀 I'll give this a more detailed look next week. |
|
@will-v-pi Something else I just thought of - might be nice to also use https://github.com/actions/labeler so that any PRs modifying files in the |
lurch
reviewed
Jun 17, 2025
| on: | ||
| push: | ||
| paths: | ||
| - 'src/boards/include/boards/**' |
There was a problem hiding this comment.
I guess there's probably no reason that this shouldn't be shortened to just 'src/boards/**', given that nothing else lives in that directory?
lurch
reviewed
Jun 17, 2025
| # Python <3.11 doesn't have ExceptionGroup, so define a simple one | ||
| class ExceptionGroup(Exception): | ||
| def __init__(self, message, errors): | ||
| message += "\n" + "\n".join(e.__str__() for e in errors) |
There was a problem hiding this comment.
Would it be better to use str(e) rather than e.__str__() ?
lurch
reviewed
Jun 17, 2025
kilograham
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub action to run
check_all_board_headers.sh, but only when either the board headers are updated, or the scripts are updatedAlso modify the
check_board_header.pyscript to create multiple exceptions as it goes, and only raise them when necessary, so that you get more errors at once in the output (rather than just getting the first error it finds)For an example of the errors this will throw, see https://github.com/will-v-pi/pico-sdk/actions/runs/15611738462/job/43974078599
Maintains compatibility with Python < 3.11 for running locally, as
ExceptionGroupwas added then