[2.2.0] Cherry-pick ARM64 wheel build #31566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only build linux wheels for x86_64. This means that users e.g. on Mac M1 machines can't run Ray in docker, as this would require linux/aarch64 (arm64) architecture wheels. This PR updates our CI to: - Install bazel for arm64 architecture - Build and upload wheels for arm64 architecture Signed-off-by: Kai Fricke <[email protected]>
pcmoritz
approved these changes
Jan 10, 2023
|
Glad to see you also put the 3.11 wheel links into this :) |
|
It will not overwrite any pypi wheels, but it will re-build the docker images and the documentation. This will also add the nightly ARM wheel links to the installation page. Happy either way - I'm uploading the ARM64 wheels to PyPI as we speak. |
|
Thanks for supporting arm64!! You have no idea how long I've been waiting for this. |
|
I'm pretty sure that the failing tests are unrelated to the changes in this PR. I think we can still hold off on merging to not affect any existing artifacts. The doc changes are reflected on master and will be reflected in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We've added support for ARM64 wheels in #31522. This builds nightly wheels - however, we currently don't have any wheels uploaded to PyPI, as we didn't build any wheels for 2.2.0.
This PR cherry-picks the ARM build PR onto the 2.2.0 branch to build wheels that can then be uploaded to PyPI.
We don't necessarily have to merge this PR - the build job should be triggered by Buildkite automatically, so we can upload the artifact wheels.
Related issue number
Closes #21786
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.