RDKEMW-3408: ctrlm IR Database C-style interface #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ctrlm-main Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
still need to test UEI. Still some more work to do to remove unecessary ctrlm header includes from ctrlm_irdb.h for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
* update CHANGELOG for controlMgr release 1.0.8 (#25) * RDKEMW-3564 : Audio samples is always reported as 0 for FFV sessions Reason for change: don't print bytes/samples when not available. Test Procedure: See Jira Risks: See Jira Priority: See Jira Signed-off-by: dwolav200 <[email protected]> * RDKEMW-3605: Remove 'volatile' type qualifier of "binding_in_progress" Fix ctrlm-main compilation error with glib 2.72. * RDKEMW-3737:Upgrading the halif-headers as iarmmgr (#30) Reason for change: Removing the plat_ir.h from ctrlm for irMgr removal Test Procedure: Build and verify * update CHANGELOG for controlMgr release 1.0.9 (#35) * RDKEMW-3609 : extend adpcm frame info (#28) extend adpcm frame info --------- Co-authored-by: dwolaver <[email protected]> Co-authored-by: Andrzej Surdej <[email protected]> Co-authored-by: Sonajeya31 <[email protected]>
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
egalla204
changed the title
* update CHANGELOG for controlMgr release 1.0.8 (#25) * RDKEMW-3564 : Audio samples is always reported as 0 for FFV sessions Reason for change: don't print bytes/samples when not available. Test Procedure: See Jira Risks: See Jira Priority: See Jira Signed-off-by: dwolav200 <[email protected]> * RDKEMW-3605: Remove 'volatile' type qualifier of "binding_in_progress" Fix ctrlm-main compilation error with glib 2.72. * RDKEMW-3737:Upgrading the halif-headers as iarmmgr (#30) Reason for change: Removing the plat_ir.h from ctrlm for irMgr removal Test Procedure: Build and verify * update CHANGELOG for controlMgr release 1.0.9 (#35) * RDKEMW-3609 : extend adpcm frame info (#28) extend adpcm frame info * RDK-56578 : Changed deviceType from tv to IpTv. (#34) The "devicetype" property of DeviceInfo thunder Plugin returns "IpTv" instead of "tv" for TV devices. --------- Co-authored-by: dwolaver <[email protected]> Co-authored-by: Andrzej Surdej <[email protected]> Co-authored-by: Sonajeya31 <[email protected]> Co-authored-by: sborushevsky <[email protected]>
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
https://github.com/rdkcentral/control into feature/RDKEMW-3151_remove_thunder_iarm_from_irdb_hal
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
https://github.com/rdkcentral/control into feature/RDKEMW-3151_remove_thunder_iarm_from_irdb_hal
plugin doesn't break the build Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
https://github.com/rdkcentral/control into feature/RDKEMW-3151_remove_thunder_iarm_from_irdb_hal
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
and V Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
Reason for change: Test Procedure: Risks: Low Signed-off-by: Gene Gallagher <[email protected]>
dwolaver
approved these changes
May 14, 2025
| } | ||
| XLOGD_INFO("Controller <%s> IRDBs supported = <%s>", | ||
| ieee_address_get().to_string().c_str(), ctrlm_ble_irdbs_supported_str(getSupportedIrdbs()).c_str()); | ||
| XLOGD_INFO("Controller <%s> IRDBs supported bitmask = <0x%X>", |
There was a problem hiding this comment.
Can we query the irdb to resolve the bitmask to human readable strings?
| @@ -635,7 +629,7 @@ void ctrlm_obj_controller_ble_t::print_status() { | |||
| XLOGD_INFO("Wakeup Config Custom List : %s", wakeupCustomListToString().c_str()); | |||
| } | |||
| XLOGD_INFO(""); | |||
| XLOGD_INFO("IR Database Supported : %s", ctrlm_ble_irdbs_supported_str(irdbs_supported_).c_str()); | |||
| XLOGD_INFO("IR Database Support Bitmask : 0x%X", irdbs_supported_); | |||
There was a problem hiding this comment.
same here. it would be best to print human readable string for this. It's ok to print the bitmask too if you find that useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move iarm and thunder dependencies from ctrlm-hal-irdb to ctrlm-main