Skip to content

fix: container xcodeproj location resolution #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vadko
Copy link

@Vadko Vadko commented May 30, 2025

Summary

Since the xcodeproj location in xcworkspacedata can be under the container: prefix, this needs to be accounted for when resolving its path. This PR fixes the issue in a similar way to how the group: prefix is handled.

Test Plan

This PR includes a unit test to verify that an xcworkspacedata file is processed correctly. I also tested building a real project using the updated CLI changes.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

@Vadko Vadko requested a review from cipolleschi as a code owner May 30, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant