Do not reference System.Text.Json for .NET 8+ #4019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reactiveui#3933 mistakenly removed the target framework condition for STJ. Referencing the STJ package on .NET 8+ causes the STJ source generator to run twice, resulting in build errors. See dotnet/wpf#8943.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4019 +/- ##
==========================================
+ Coverage 59.03% 63.27% +4.23%
==========================================
Files 160 137 -23
Lines 5847 5193 -654
Branches 1031 785 -246
==========================================
- Hits 3452 3286 -166
+ Misses 2007 1702 -305
+ Partials 388 205 -183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
database64128
added a commit
to database64128/youtube-dl-wpf
that referenced
this pull request
Apr 24, 2025
Revert this once reactiveui/ReactiveUI#4019 is merged and out in a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3933 mistakenly removed the target framework condition for STJ. Referencing the STJ package on .NET 8+ causes the STJ source generator to run twice, resulting in build errors. See dotnet/wpf#8943.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Build errors for projects referencing ReactiveUI and using STJ source generation at the same time.
What is the new behavior?
No build errors.
What might this PR break?
Please check if the PR fulfills these requirements
Other information: