-
Notifications
You must be signed in to change notification settings - Fork 7
Post: Welcome to our GitHub App #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new blog post announcing the migration from a legacy GitHub OAuth2 application to a modern GitHub App. The post details the benefits of GitHub Apps, what to expect during the transition, and provides guidance for existing and new users.
- Adds a new markdown file with post metadata and content.
- Details the reasons for the change and the expected user impact.
- Includes appropriate external links and image credits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but seems like it's not mentioning any specific dates or anything? We should at least note when we're planning to do this, or is this just a draft until we move forward with it?
Yeah, this should be posted after we actually ship the feature to all users. |
Co-authored-by: Eric Holscher <[email protected]>
Updated the blog post to mention the beta instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with some suggestions.
- If you are an existing user with your GitHub account already linked to Read the Docs, | ||
you can start the migration process [from this page](https://readthedocs.org/accounts/migrate-to-github-app/). | ||
- If you are a new user, you can sign up using the new GitHub App [from this page](https://readthedocs.org/accounts/githubapp/login/). | ||
- If you are an existing user, but you don't have your GitHub account linked to Read the Docs, | ||
you can link your GitHub account to our new GitHub App [from this page](https://readthedocs.org/accounts/githubapp/login/?process=connect). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change all these from this page
links to some text more relevant in each case. They all look the same now which is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the one referencing the migration page, not sure what to put for the other two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
📚 Documentation preview 📚: https://readthedocs-about--357.org.readthedocs.build/