Skip to content

Application-layer new-cluster automation #6226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Application-layer new-cluster automation #6226

merged 3 commits into from
Apr 30, 2025

Conversation

ralphbean
Copy link
Member

@ralphbean ralphbean commented Apr 24, 2025

One thing that's up in the air here is dealing with the valero backup key. I assume that is waiting on some new work to be done in the cluster-level automation and can be followed up on later.

This is ready for review.

@manish-jangra
Copy link
Contributor

manish-jangra commented Apr 26, 2025

@ralphbean If you're referring to kms key for the velero backup in the description of this PR, we will not use that anymore for new environments as we're creating s3 bucket (for velero backup) using the default s3 encryption managed by aws itself. We can always change that if we need to and change terraform module to create kms key for the velero backup.

@ralphbean
Copy link
Member Author

@manish-jangra ah, thanks for the tip about the valero key - that is what I was referring to. I'll drop those comments in the yaml and update the description here.

Sometimes, .openshiftapps can be preceded by p2 or p3.
@ralphbean ralphbean requested a review from manish-jangra April 29, 2025 11:36
Copy link
Contributor

@manish-jangra manish-jangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manish-jangra, ralphbean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [manish-jangra,ralphbean]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ece51da into main Apr 30, 2025
11 checks passed
@ralphbean ralphbean deleted the template branch May 1, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants