fix: create lazy OpenShift context to avoid check timeouts (#865) #866
Conversation
adietish
force-pushed
the
issue-865
branch
9 times, most recently
from
6c87476 to
f8af258
Compare
adietish
changed the title
| * @see [issue 865](https://github.com/redhat-developer/intellij-kubernetes/issues/865) | ||
| * @see ClientAdapter.toOpenShift | ||
| **/ | ||
| return KubeClientAdapter(kubeClient) |
There was a problem hiding this comment.
this is the core of the fix: dont check if the cluster is OpenShift and create a Kubernetes- or OpenShift client. This check is costly and may timeout if the cluster is not reachable.
Create a Kubernetes client instead. It can always be adapted to an OpenShift client when needed.
| client as KubeClientAdapter | ||
| ) | ||
| } | ||
| return LazyOpenShiftContext(currentContext, modelChange, client as KubeClientAdapter) |
There was a problem hiding this comment.
this is the core of the fix: dont check if the cluster is OpenShift and create a Kubernetes- or OpenShift context. This check is costly and may timeout if the cluster is not reachable.
Create a Kubernetes context that async tries to upgrade to an OpenShift context instead.
| config.connectionTimeout = TIMEOUT_CONNECTION | ||
| config.requestTimeout = TIMEOUT_REQUEST | ||
| config.watchReconnectLimit = LIMIT_RECONNECT | ||
| config |
There was a problem hiding this comment.
This is an aspect of the fix: impose timeouts for connecting, requesting and reconnecting.
| } | ||
|
|
||
| private fun createOpenShiftDelegate() { | ||
| if (client.canAdaptToOpenShift()) { |
There was a problem hiding this comment.
this is the core fix: a context that starts as a Kubernetes context and async tries to create and use an OpenShift context.
Signed-off-by: Andre Dietisheim <[email protected]>
Signed-off-by: Andre Dietisheim <[email protected]>
adietish
force-pushed
the
issue-865
branch
2 times, most recently
from
d5e8a39 to
83a3b6b
Compare
src/main/kotlin/com/redhat/devtools/intellij/kubernetes/model/context/LazyOpenShiftContext.kt
Outdated
Show resolved
Hide resolved
…veloper#865) Signed-off-by: Andre Dietisheim <[email protected]>
|
adietish
requested review from
msivasubramaniaan
and removed request for
sbouchet
|
@sbouchet: handing this to @msivasubramaniaan to unload you so that you can please review #858 |
adietish
requested review from
andrewballantyne and
sbouchet
and removed request for
andrewballantyne and
sbouchet
fixes #865