fix: enable heavy JAXP operations on a Java 24

[mamilic]

This PR addresses this issue, eclipse-jdtls/eclipse.jdt.ls#3465

Adds system properties to disable JAXP limits

[mamilic]

Hi @rgrunber , I was wondering if tests are needed for the params added?

[rgrunber]

This fixes the issue. No need for tests in this case. The only thing I'd add is a comment above the if-statement (eg. if (requirements.tooling_jre_version >= 24) { ) linking to the JDT-LS issue, eclipse-jdtls/eclipse.jdt.ls#3465 .

Also I'd rename the title of the commit to :

"Remove JAXP entity limits when runtime is Java 24 or higher"

[mamilic]

Hi @rgrunber , I've made changes, does it look fasible now?

[Ninjadeveloper007]

I approve this `From 159fde8 Mon Sep 17 00:00:00 2001
From: Marko Milic [email protected]
Date: Thu, 12 Jun 2025 07:43:32 +0200
Subject: [PATCH] Remove JAXP entity limits when runtime is Java 24 or higher

Signed-off-by: Marko Milic [email protected]

src/javaServerStarter.ts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/src/javaServerStarter.ts b/src/javaServerStarter.ts
index 19ebf744e..d9f10aea2 100644
--- a/src/javaServerStarter.ts
+++ b/src/javaServerStarter.ts
@@ -96,6 +96,13 @@ function prepareParams(requirements: RequirementsData, workspacePath, context: E
// params.push('-agentlib:jdwp=transport=dt_socket,server=y,address=1044');
}

• // See Performing heavy JAXP operations on a Java 24 runtime can fail due to limits eclipse-jdtls/eclipse.jdt.ls#3465
• if (requirements.tooling_jre_version >= 24) {

•   params.push('-Djdk.xml.maxGeneralEntitySizeLimit=0',
  

•   			'-Djdk.xml.totalEntitySizeLimit=0'
  

•   			);
  

• }
• params.push('--add-modules=ALL-SYSTEM',
  '--add-opens',
  'java.base/java.util=ALL-UNNAMED',`