Skip to content

architecture aware benchmark client link downloads #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redisbench-admin"
version = "0.11.26"
version = "0.11.28"
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
authors = ["filipecosta90 <[email protected]>","Redis Performance Group <[email protected]>"]
readme = "README.md"
Expand Down
8 changes: 6 additions & 2 deletions redisbench_admin/run/ftsb/ftsb.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,16 @@


def extract_ftsb_extra_links(
benchmark_config, benchmark_tool, config_key="clientconfig"
benchmark_config, benchmark_tool, config_key="clientconfig", architecture="x86_64"
):
remote_tool_link = "/tmp/{}".format(benchmark_tool)
arch_txt = "amd64"
if architecture == "aarch64":
arch_txt = "arm64"

Check warning on line 63 in redisbench_admin/run/ftsb/ftsb.py

View check run for this annotation

Codecov / codecov/patch

redisbench_admin/run/ftsb/ftsb.py#L61-L63

Added lines #L61 - L63 were not covered by tests

tool_link = (
"https://s3.amazonaws.com/benchmarks.redislabs/"
+ "redisearch/tools/ftsb/{}_linux_amd64".format(benchmark_tool)
+ f"redisearch/tools/ftsb/{benchmark_tool}_linux_{arch_txt}"
)
queries_file_link = None
for entry in benchmark_config[config_key]:
Expand Down
2 changes: 2 additions & 0 deletions redisbench_admin/run_remote/remote_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def run_remote_client_tool(
redis_conns=[],
do_post_process=True,
redis_password=None,
architecture="x86_64",
):
(
benchmark_min_tool_version,
Expand Down Expand Up @@ -83,6 +84,7 @@ def run_remote_client_tool(
arch_str,
client_ssh_port,
private_key,
architecture,
)
if "ann-benchmarks" in benchmark_tool:
logging.info(
Expand Down
2 changes: 2 additions & 0 deletions redisbench_admin/run_remote/remote_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def remote_db_spin(
ignore_keyspace_errors=False,
continue_on_module_check_error=False,
keyspace_check_timeout=60,
architecture="x86_64",
):
(
_,
Expand Down Expand Up @@ -337,6 +338,7 @@ def remote_db_spin(
[],
False,
redis_password,
architecture,
)
logging.info(
"Finished loading the data via client tool. Took {} seconds. Result={}".format(
Expand Down
9 changes: 7 additions & 2 deletions redisbench_admin/run_remote/remote_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,11 @@
arch_str,
client_ssh_port,
private_key,
architecture="x86_64",
):
logging.info("Settting up remote tool {} requirements".format(benchmark_tool))
logging.info(

Check warning on line 71 in redisbench_admin/run_remote/remote_helpers.py

View check run for this annotation

Codecov / codecov/patch

redisbench_admin/run_remote/remote_helpers.py#L71

Added line #L71 was not covered by tests
f"Settting up remote tool {benchmark_tool} requirements. architecture ={architecture}"
)
if benchmark_tool == "redisgraph-benchmark-go":
setup_remote_benchmark_tool_redisgraph_benchmark_go(
client_public_ip,
Expand All @@ -90,7 +93,9 @@
queries_file_link,
remote_tool_link,
tool_link,
) = extract_ftsb_extra_links(benchmark_config, benchmark_tool, config_key)
) = extract_ftsb_extra_links(
benchmark_config, benchmark_tool, config_key, architecture
)
logging.info(
"FTSB Extracted:\nremote tool input: {}\nremote tool link: {}\ntool path: {}".format(
queries_file_link, remote_tool_link, tool_link
Expand Down
3 changes: 3 additions & 0 deletions redisbench_admin/run_remote/run_remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,8 @@ def run_remote_command_logic(args, project_name, project_version):
flushall_on_every_test_start,
ignore_keyspace_errors,
continue_on_module_check_error,
60,
architecture,
)
if benchmark_type == "read-only":
ro_benchmark_set(
Expand Down Expand Up @@ -698,6 +700,7 @@ def run_remote_command_logic(args, project_name, project_version):
redis_conns,
True,
redis_password,
architecture,
)

if profilers_enabled:
Expand Down
5 changes: 4 additions & 1 deletion redisbench_admin/utils/remote.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import os
import sys
import tempfile

import time
import git
import paramiko
import pysftp
Expand Down Expand Up @@ -314,6 +314,9 @@
},
raise_on_error=True,
)
infra_wait_secs = 60
logging.warning("Infra ready wait... for {infra_wait_secs} secs")
time.sleep(infra_wait_secs)

Check warning on line 319 in redisbench_admin/utils/remote.py

View check run for this annotation

Codecov / codecov/patch

redisbench_admin/utils/remote.py#L317-L319

Added lines #L317 - L319 were not covered by tests
return retrieve_tf_connection_vars(return_code, tf)


Expand Down