ci: update github actions, add publish workflow for version tags #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcobzarenco
approved these changes
Jul 8, 2020
scripts/build
Outdated
| set -ex | ||
|
|
||
| cargo check --all-targets --all-features --locked | ||
| cargo build --locked --all-targets --all-features |
There was a problem hiding this comment.
Something I ran into before, suprisingly --all-targets doesn't run doc tests, whereas cargo test would. I don't think we have any examples in the docs, but may be worth adding cargo test --docs ... too so we don't forget.
Also, suuupper nit. the arguments could be in same order
There was a problem hiding this comment.
Good point - yes, I feel like I've been annoyed about that before.
Have un-nitted the arguments, and removed some duplicate/redundant flags (like, we don't need --all-features because we have no features at the moment).
tommilligan
force-pushed
the
actions-publish
branch
2 times, most recently
from
77ffbec to
4333869
Compare
tommilligan
force-pushed
the
actions-publish
branch
from
4333869 to
8060ae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds caching for rust dependencies, which should speed up build times.
This will definitely not work until the following secrets are populated by an admin (@mcobzarenco):
GCP_SA_KEY, a GCP Service Account Key which has write access to thegs://reinfer-publicbucketCRATES_IO_TOKEN, a crates.io token with publish permissions to thereinfer-cliandreinfer-clientcrates.