Parse regex to calculate accurate types for generatePath
#13436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
generatePath('/pages/:page(comments|latest_activity)')
by parsing the regex, we should be able to automatically enforce that thepage
parameter is one ofcomments | latest_activity
.This PR implements that parsing:
If the path contains regex symbols like
:page(\d+|activity)
then it will not try to parse the types.This could be a breaking change if anyone is incorrectly calling generatePath with arguments that aren't part of the
(|)
in the regexp.