build(next): Simplify test setup #112
Merged
+276
−553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thien-remote
commented
Jan 22, 2025
| @@ -7,6 +7,7 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| "skipLibCheck": true | |||
| }, | |||
| "include": ["src"], | |||
| "exclude": ["node_modules", "dist"] | |||
There was a problem hiding this comment.
The removal is intentional. The naming may be intuitive, but "exclude" only has impact over "include". In other words, we don't need to "exclude" the paths that are not in "include" at all.
dragidavid
reviewed
Jan 22, 2025
babel.config.js
Outdated
There was a problem hiding this comment.
I'm pretty sure (pun intended) that we have different prettier settings since if I just save this file, it brings back the multi line format 😂
dragidavid
reviewed
Jan 22, 2025
next/README.md
Outdated
There was a problem hiding this comment.
Thanks for adding this
thien-remote
commented
Jan 22, 2025
| @@ -0,0 +1 @@ | |||
| 22.13.1 | |||
There was a problem hiding this comment.
Do you want to keep this @dragidavid ? It's a really long story, but usually I'd suggest to just have one reference, to reduce the risk of out-of-sync in the future 🤔
Not big enough to be a change request though. Could be convenient for folks with NVM, which at the moment is Remote's default setup.
thien-remote
added a commit
that referenced
this pull request
Jan 23, 2025
* tests(next): add packages * tests(next): implement absolute path * tests(next): reuse existing tests but with different imports * build(next): Simplify test setup (#112) * Fix * Update jest.config.js * Update babel.config.js * chore: add default node version --------- Co-authored-by: David Dragovacz <david.dragovacz@remote.com> * chore: add node version to readme * chore: apply changes based on review --------- Co-authored-by: thien-remote <159022487+thien-remote@users.noreply.github.com>
dragidavid
added a commit
that referenced
this pull request
Jan 23, 2025
* Fix * Update jest.config.js * Update babel.config.js * chore: add default node version --------- Co-authored-by: David Dragovacz <david.dragovacz@remote.com>
dragidavid
added a commit
that referenced
this pull request
Jan 28, 2025
* Fix * Update jest.config.js * Update babel.config.js * chore: add default node version --------- Co-authored-by: David Dragovacz <david.dragovacz@remote.com>
dragidavid
added a commit
that referenced
this pull request
Jan 31, 2025
* tests(next): reuse existing tests but with different imports * build(next): Simplify test setup (#112) * Fix * Update jest.config.js * Update babel.config.js * chore: add default node version --------- Co-authored-by: David Dragovacz <david.dragovacz@remote.com> * chore: apply changes based on review * build(next): add release script based on existing ones * build(next): add release:next scripts * chore: make changes based on review * build(next): adjust release script * Release next 1.0.0-alpha.1 * build(next): change release script - includes separate `dev` and `beta` versions - `dev` will work the same way as the main `dev` script that we have where we append the version with the timestamp - `beta` will increment the version in the `/next/package.json` file * build(next): add new scripts * build(next): do not update package.json with dev versions * build(next): adjust script to always use the current version * Release v1-beta 1.0.0-beta.1 * build(next): add `files` to package.json * build(next): correct main entry * Release v1-beta 1.0.0-beta.2 * build(next): release rules prevents the `dev` release when on `main` branch only allows a `beta` release when on `main` branch and local branch up to date * build(next): simplify `bumpVersion` * build(next): generate changelog for beta releases * fix: versioning bug * build(next): check dev version restriction - this checks the version in the `next` package before merging and fails if it is anything other than `beta` - this commit should make the build fail since I'm checking if it is `beta` (for testing purposes) * build(next): correcting version check * chore: reset version --------- Co-authored-by: thien-remote <159022487+thien-remote@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the test setup in #111, as per @thien-remote 's first review. It is intentionally extracted as another PR to avoid invalidating the review. It should also make it easier to follow.