-
Notifications
You must be signed in to change notification settings - Fork 13
build(next): Simplify test setup #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -7,6 +7,7 @@ | |||
"forceConsistentCasingInFileNames": true, | |||
"skipLibCheck": true | |||
}, | |||
"include": ["src"], | |||
"exclude": ["node_modules", "dist"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal is intentional. The naming may be intuitive, but "exclude" only has impact over "include". In other words, we don't need to "exclude" the paths that are not in "include" at all.
babel.config.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure (pun intended) that we have different prettier settings since if I just save this file, it brings back the multi line format 😂
next/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this
@@ -0,0 +1 @@ | |||
22.13.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to keep this @dragidavid ? It's a really long story, but usually I'd suggest to just have one reference, to reduce the risk of out-of-sync in the future 🤔
Not big enough to be a change request though. Could be convenient for folks with NVM, which at the moment is Remote's default setup.
This PR simplifies the test setup in #111, as per @thien-remote 's first review. It is intentionally extracted as another PR to avoid invalidating the review. It should also make it easier to follow.