preflight pass wording and enable HA by default #2129
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the preflight messaging and changes the default behavior for enabling high availability during node joins.
- Updated host preflight info message to use "passed" instead of "succeeded" for consistency with Troubleshoot terminology.
- Changed the default answer for the high availability prompt from “no” to “yes” for node joins.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/preflights/run.go | Updated informational message wording to match our terminology. |
| cmd/installer/cli/join.go | Changed the default value for the high availability prompt to true. |
Comments suppressed due to low confidence (1)
cmd/installer/cli/join.go:555
- The default confirmation for enabling high availability has been changed to true. Ensure that associated documentation and help messages are updated accordingly to avoid user confusion.
shouldEnableHA, err := prompts.New().Confirm("Do you want to enable high availability?", true)
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Say "preflights passed" instead of "succeeded" because that's the terminology we usually use for Troubleshoot.
When prompting about HA while joining nodes, default answer is now yes.
Which issue(s) this PR fixes:
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?