Skip to content

Replace uses of arrow2 in rerun_c with arrow-rs #9704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 13, 2025

Related

What

After this, the only arrow2 remaining is in re_types_builder

Copy link

github-actions bot commented Apr 13, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
dd12a1e https://rerun.io/viewer/pr/9704 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md 🏹 arrow Apache Arrow labels Apr 13, 2025
@emilk
Copy link
Member Author

emilk commented Apr 13, 2025

@rerun-bot full-check

Copy link

@emilk
Copy link
Member Author

emilk commented Apr 13, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/14428303816

@abey79 abey79 self-requested a review April 14, 2025 07:19
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@emilk emilk merged commit 4a9a545 into main Apr 14, 2025
36 checks passed
@emilk emilk deleted the emilk/remove-arrow2-from-rerun_c branch April 14, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow Apache Arrow 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants