Document tagged templates #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsnobip is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
zth
reviewed
Jan 29, 2024
fhammerschmidt
requested changes
Jan 31, 2024
tsnobip
force-pushed
the
tagged_templates
branch
from
5b9e336 to
4949dfe
Compare
|
Tests fail. You'd need to add "dependencies": {
...
"rescript-1100": "npm:[email protected]",
+ "rescript-1110": "npm:[email protected]",
"rescript-820": "npm:[email protected]",
...
}to |
zth
approved these changes
Feb 1, 2024
fhammerschmidt
approved these changes
Feb 1, 2024
tsnobip
force-pushed
the
tagged_templates
branch
from
82820fc to
068915d
Compare
|
You still need to change the used version in test-examples. Unfortunately, testing uses only thebmost current version for now still. |
|
thanks guys for the review, the tests pass now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of tagged templates was added by rescript-lang/rescript#6250.
This PR is meant to document this new feature that will land with v11.1.