-
-
Notifications
You must be signed in to change notification settings - Fork 249
feat: added new community content page #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying rescript-lang-org with
|
Latest commit: |
7ec2103
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f94902d5.rescript-lang.pages.dev |
Branch Preview URL: | https://vlk-977-community-tab.rescript-lang.pages.dev |
0ae6d0d
to
5f13dff
Compare
|
15095f7
to
26b992a
Compare
c8e5b3e
to
17c79d8
Compare
For some reason when I add
Running |
I removed it for now until I can sort this out. The changes to the website will work, but running the script locally will not until the issue is resolved. I'm not sure if that's blocking for merging this, or if it can be a follow up for later. |
scripts/generate_resources.res
Outdated
@@ -0,0 +1,50 @@ | |||
/** This is the list of community content we want to generate. */ | |||
/** If you have content you would like to add, please open up a PR adding the link to this list and then run `npm run generate_resources` */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment needs an update to kebap-case as well now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
this PR makes me hungry... Okay a final thing that also my colleague noticed: images with white background don't work very well with the border-less approach here. Shall we just do light grey borders and call it a day? It has to be robust for all kinds of images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. We can refine the design later, for instance when we add filters/tags.
Adds a new page to the community section to contain links to external content.
Content meta tags can be updated by running
npm run generate-resources
.Feedback on the design is welcome.
Desktop
Mobile
Tablet