Skip to content

feat: added new community content page #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 11, 2025
Merged

Conversation

jderochervlk
Copy link
Collaborator

@jderochervlk jderochervlk commented Mar 5, 2025

Adds a new page to the community section to contain links to external content.

Content meta tags can be updated by running npm run generate-resources.

Feedback on the design is welcome.

Desktop

image

Mobile

image

Tablet

image

Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 4:38pm

Copy link

cloudflare-workers-and-pages bot commented Mar 5, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7ec2103
Status: ✅  Deploy successful!
Preview URL: https://f94902d5.rescript-lang.pages.dev
Branch Preview URL: https://vlk-977-community-tab.rescript-lang.pages.dev

View logs

@fhammerschmidt
Copy link
Member

  1. Can we remove the orange outline and maybe instead highlight just the links when hovered?
  2. I still feel this whole section needs its own page (in the sidebar above roadmap), not be part of community/overview, I just don't have any good naming suggestions. It should somehow be mentioned on the overview though. Or maybe just show a handful of (recent?) resources in the overview and have a dedicated page to view all of them.
  3. Like the blog, on larger screens I would allow at least three elements in a row.

@jderochervlk
Copy link
Collaborator Author

  1. Can we remove the orange outline and maybe instead highlight just the links when hovered?

Done!

2. I still feel this whole section needs its own page (in the sidebar above roadmap), not be part of community/overview, I just don't have any good naming suggestions. It should somehow be mentioned on the overview though. Or maybe just show a handful of (recent?) resources in the overview and have a dedicated page to view all of them.

I can make this another page.

  1. Like the blog, on larger screens I would allow at least three elements in a row.

The parent container has a fixed width, so showing 3 items breaks most of the og:images
image

@jderochervlk
Copy link
Collaborator Author

For some reason when I add jsdom to dev dependencies the ci job fails: https://github.com/rescript-lang/rescript-lang.org/actions/runs/13789658543/job/38565930923#step:4:7

npm error npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Running npm i doesn't change anything for me locally and all I ran was npm i jsdom -D and the output fails CI for some reason.
I'm on Ubuntu and I am using nvm to use Node 20, the same version as CI.

@jderochervlk
Copy link
Collaborator Author

For some reason when I add jsdom to dev dependencies the ci job fails: https://github.com/rescript-lang/rescript-lang.org/actions/runs/13789658543/job/38565930923#step:4:7

npm error npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Running npm i doesn't change anything for me locally and all I ran was npm i jsdom -D and the output fails CI for some reason. I'm on Ubuntu and I am using nvm to use Node 20, the same version as CI.

I removed it for now until I can sort this out. The changes to the website will work, but running the script locally will not until the issue is resolved.

I'm not sure if that's blocking for merging this, or if it can be a follow up for later.

@@ -0,0 +1,50 @@
/** This is the list of community content we want to generate. */
/** If you have content you would like to add, please open up a PR adding the link to this list and then run `npm run generate_resources` */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment needs an update to kebap-case as well now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@fhammerschmidt
Copy link
Member

this PR makes me hungry...

Okay a final thing that also my colleague noticed: images with white background don't work very well with the border-less approach here.

Shall we just do light grey borders and call it a day? It has to be robust for all kinds of images.

@jderochervlk
Copy link
Collaborator Author

Shall we just do light grey borders and call it a day? It has to be robust for all kinds of images.

I added a gray-30 border:
image

40 felt too dark, and 20 felt too light.

Copy link
Member

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We can refine the design later, for instance when we add filters/tags.

@fhammerschmidt fhammerschmidt merged commit f233d14 into master Mar 11, 2025
4 checks passed
@jderochervlk jderochervlk deleted the vlk-977-community-tab branch March 11, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants