Skip to content

Compile runtime with rewatch and add rewatch tests to the compiler repo #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
May 17, 2025

Conversation

jfrolich
Copy link
Contributor

@jfrolich jfrolich commented May 5, 2025

No description provided.

Copy link

pkg-pr-new bot commented May 5, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7422

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7422

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7422

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7422

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7422

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7422

commit: 759b882

@jfrolich jfrolich force-pushed the rewatch-runtime branch from 6d34eac to e7af0b9 Compare May 5, 2025 12:10
@jfrolich jfrolich changed the title Compile runtime with rewatch and make rewatch the default build system Compile runtime with rewatch and add rewatch tests to the compiler repo May 5, 2025
@jfrolich jfrolich force-pushed the rewatch-runtime branch from 456a012 to 71b39d4 Compare May 8, 2025 19:57
@@ -20,6 +20,32 @@ env:
OCAMLRUNPARAM: b

jobs:
test-rewatch-integration:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real integration test of both rewatch + bsc packaged up in the test repo, to make sure it works end to end

Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cknitt
Copy link
Member

cknitt commented May 15, 2025

Ah, CI still builds the runtime with bsb?
Can we change that to rewatch?

@cknitt cknitt force-pushed the rewatch-runtime branch from 0bafcb8 to 585f926 Compare May 17, 2025 06:10
@cknitt cknitt merged commit 0e718c5 into master May 17, 2025
16 checks passed
@cknitt cknitt deleted the rewatch-runtime branch May 17, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants