Clean up lazy from ASTs and back-end. #7474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that lazy is handled user-side, there's a bunch of unused code. The type `lazy_t` is still predefined, and module `Primitive_lazy.res` still exists. Perhaps `lazy_t` can be moved user side too, and `Primitive_lazy` just moved into `Stdlib_lazy`, which seems just a wrapper for it at the moment.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
|
Should we also remove built in lazy_t, and move Primitive_lazy into the stdlib lazy module. |
Yes, I can do the stdlib stuff in a separate PR if you like.
Not that I know of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that lazy is handled user-side, there's a bunch of unused code.
The type
lazy_tis still predefined, and modulePrimitive_lazy.resstill exists. Perhapslazy_tcan be moved user side too, andPrimitive_lazyjust moved intoStdlib_lazy, which seems just a wrapper for it at the moment.