Skip to content

Fill out memoryapi #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 3, 2017
Merged

Fill out memoryapi #497

merged 5 commits into from
Oct 3, 2017

Conversation

docbrown
Copy link
Contributor

No description provided.

@docbrown
Copy link
Contributor Author

Needs #466 first.

@docbrown
Copy link
Contributor Author

Test are failing with:

Doc-tests winapi
error: An unknown error occurred

They pass on my machine, though. Hmmm...

@retep998
Copy link
Owner

You have functions in memoryapi which come from a different library than kernel32. Specifically MapViewOfFileNuma2 which comes from one of onecore/onecoreuap/mincore/mmos. In Rust 1.6 inline functions, such as MapViewOfFile2, are not lazily instantiated and ld fails to strip unreferenced functions so it fails to link. I'm not entirely sure why the doc test fails on current Rust but my guess is that it depends on a symbol which only exists on a newer version of Windows than Appveyor has.

@retep998
Copy link
Owner

Doc tests failing because of rust-lang/rust#44487

@Susurrus
Copy link
Contributor

@retep998 This good to merge now?

@Susurrus Susurrus mentioned this pull request Sep 24, 2017
Closed
9 tasks
@retep998
Copy link
Owner

@retep998 retep998 merged commit fc01314 into retep998:dev Oct 3, 2017
@docbrown docbrown deleted the memoryapi branch October 3, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@docbrown @retep998 @Susurrus