simplify HeadPathResponse try_from #2
Conversation
| @@ -87,18 +87,17 @@ pub struct HeadPathResponse { | |||
| pub common_storage_response_headers: CommonStorageResponseHeaders, | |||
| pub etag: String, | |||
| pub last_modified: DateTime<Utc>, | |||
| pub properties: Option<Properties>, | |||
There was a problem hiding this comment.
Hi Cameron, thanks for the response!
This needs to be an Option because Properties, in this context, is equal to x-ms-properties, and this header only gets returned when you don't specify an action. See the docs here. The previous implementation didn't consider it optional because GetProperties was the only implementation that existed. However, to support GetStatus (a derivation of GetProperties), it will need to be optional to support both. Hence the reason for changing this to an Option. Without this, the API response cannot be processed correctly. Take a look at the test I wrote for this function for context, specifically here and here. You will see that when the action is GetStatus, that x-ms-properties is not returned.
For Azure#722