target/riscv: Add support for external triggers #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lz-bro
force-pushed
the
add-external-triggers
branch
2 times, most recently
from
a066280 to
3f63412
Compare
|
I want to continue the implementation of the external triggers for halt/resume groups base on @rbradford‘s work，But current implementation has not yet completed the resume group for external triggers。If I want to implement it, what do I need to pay attention to? What I can confirm now is that a diable haltgroup is required before the step, and the haltgroup will be restored after the step. @JanMatCodasip, @aap-sc could you please take a look and give some suggestions? |
rbradford
reviewed
Mar 31, 2025
| } | ||
| int value = atoi(CMD_ARGV[i + 1]); | ||
| if (value <= 0 || value > 16) { | ||
| LOG_ERROR("%s is not a valid integer argument for command.", CMD_ARGV[i + 1]); |
There was a problem hiding this comment.
This came up in the previous review - 0 is a valid external trigger. Also 16 is not a valid - so should this be (value < 0 || value >= 16)
|
Thank you for restarting this work. |
lz-bro
force-pushed
the
add-external-triggers
branch
from
3f63412 to
bf7c3ac
Compare
Add support for associating a halt/resume group with an external trigger via a newly exposed configuration option "riscv smp_add_ext_triggers". Original merge request: riscv-collab#1179 Original author: Rob Bradford [email protected] https://github.com/rbradford
lz-bro
force-pushed
the
add-external-triggers
branch
from
bf7c3ac to
8216d33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for associating a halt/resume group with an external trigger via a newly exposed configuration option "riscv smp_add_ext_triggers".
Original merge request:
#1179
Original author: Rob Bradford
[email protected]
https://github.com/rbradford