Skip to content

chore: wip don't allow additionalProperties in rest of jsonschema files #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kbroch-rivosinc
Copy link
Collaborator

@kbroch-rivosinc kbroch-rivosinc commented May 27, 2025

Brought up by @ThinkOpenly here: #811 (comment)

❯ pre-commit run --all-files check-jsonschema
Validate instruction files with jsonschema...............................Passed
Validate CSR files with jsonschema.......................................Passed
Validate extension files with jsonschema.................................Passed
Validate cert model files with jsonschema................................Passed
Validate cert class files with jsonschema................................Passed
Validate profile family files with jsonschema........(no files to check)Skipped
Validate profile release files with jsonschema...........................Failed
- hook id: check-jsonschema
- exit code: 1

Schema validation errors were encountered.
  arch/profile_release/Mock.yaml::$: Additional properties are not allowed ('class', 'contributors', 'description', 'introduction', 'long_name', 'marketing_name', 'profiles', 'ratification_date', 'release', 'state', 'versions' were unexpected)
  arch/profile_release/RVA22.yaml::$: Additional properties are not allowed ('class', 'contributors', 'description', 'introduction', 'long_name', 'marketing_name', 'profiles', 'ratification_date', 'release', 'state', 'versions' were unexpected)
  arch/profile_release/RVI20.yaml::$: Additional properties are not allowed ('base', 'class', 'contributors', 'description', 'introduction', 'long_name', 'marketing_name', 'profiles', 'ratification_date', 'state', 'versions' were unexpected)
  arch/profile_release/RVA20.yaml::$: Additional properties are not allowed ('class', 'contributors', 'description', 'introduction', 'long_name', 'marketing_name', 'profiles', 'ratification_date', 'release', 'state', 'versions' were unexpected)
Schema validation errors were encountered.
  arch/profile_release/RVA23.yaml::$: Additional properties are not allowed ('class', 'description', 'introduction', 'long_name', 'marketing_name', 'profiles', 'ratification_date', 'release', 'state', 'versions' were unexpected)
  arch/profile_release/RVB23.yaml::$: Additional properties are not allowed ('class', 'description', 'introduction', 'long_name', 'marketing_name', 'profiles', 'ratification_date', 'release', 'state', 'versions' were unexpected)

@kbroch-rivosinc kbroch-rivosinc self-assigned this May 27, 2025
@kbroch-rivosinc kbroch-rivosinc marked this pull request as draft May 27, 2025 21:55
@kbroch-rivosinc kbroch-rivosinc changed the title chore: wip chore: wip don't allow additionalProperties in rest of jsonschema files May 27, 2025
@kbroch-rivosinc kbroch-rivosinc force-pushed the dev/kbroch/additionalproperties-false branch from f2d85a8 to c525eb7 Compare May 29, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant