[io] Fix TFile::WalkTKeys mishandling strings longer than 127 characters #19011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
force-pushed
the
tfile_walkkeys_fix
branch
from
56793f1 to
e19a83f
Compare
silverweed
changed the title
pcanal
reviewed
Jun 11, 2025
Test Results 19 files 19 suites 3d 16h 15m 17s ⏱️ For more details on these failures, see this check. Results for commit ca2300f. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
tfile_walkkeys_fix
branch
from
e19a83f to
ca2300f
Compare
|
@pcanal can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a signed
charis incorrect, as strings in root files can be up to 255 characters long (as far as I understand).Checklist: