-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cppyy] disable tests failing with mac-beta ARM64 #19069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e21c390
to
8d129c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Test Results 19 files 19 suites 3d 12h 8m 25s ⏱️ Results for commit 7181a75. ♻️ This comment has been updated with latest results. |
I don't want to actively block this PR, but do we understand why these tests are failing? At the very least, this should be mentioned in the commit message. It would probably be better to add a comment in the test itself, or even a GitHub issue that is linked from that comment. |
8d129c5
to
7181a75
Compare
I think @hahnjo has a point: it's good we can easily exclude the tests, but we should try to fix the root cause of the failure before curing the symptom to then be hit at a later stage by the underlying problem. |
This is not strictly a cppyy problem. These tests fail (mostly) due to ABI changes:
and
Currently these tests only fail on mac beta and pass on the stable SDKs on ARM. I believe we need to annotate |
fails while compiling codegen from callfunc due to changes in libc++ (ABI)
7181a75
to
d0901ae
Compare
Disabling tests that fail on mac-beta ARM64