Skip to content

[cppyy] disable tests failing with mac-beta ARM64 #19069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

Vipul-Cariappa
Copy link
Contributor

Disabling tests that fail on mac-beta ARM64

Copy link
Contributor

@aaronj0 aaronj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Vipul-Cariappa Vipul-Cariappa requested a review from aaronj0 June 17, 2025 15:19
Copy link

github-actions bot commented Jun 17, 2025

Test Results

    19 files      19 suites   3d 12h 8m 25s ⏱️
 2 853 tests  2 853 ✅ 0 💤 0 ❌
52 707 runs  52 707 ✅ 0 💤 0 ❌

Results for commit 7181a75.

♻️ This comment has been updated with latest results.

@hahnjo
Copy link
Member

hahnjo commented Jun 18, 2025

I don't want to actively block this PR, but do we understand why these tests are failing? At the very least, this should be mentioned in the commit message. It would probably be better to add a comment in the test itself, or even a GitHub issue that is linked from that comment.

@dpiparo
Copy link
Member

dpiparo commented Jun 18, 2025

I think @hahnjo has a point: it's good we can easily exclude the tests, but we should try to fix the root cause of the failure before curing the symptom to then be hit at a later stage by the underlying problem.

@Vipul-Cariappa
Copy link
Contributor Author

Yes. I agreed with @hahnjo, I will need some time to figure that out.
Also, I don't have access to a machine with OSX. Usually, @aaronj0 helps me out when I face problems on OSX, but he is in Sofia right now.

@aaronj0
Copy link
Contributor

aaronj0 commented Jun 18, 2025

Yes. I agreed with @hahnjo, I will need some time to figure that out. Also, I don't have access to a machine with OSX. Usually, @aaronj0 helps me out when I face problems on OSX, but he is in Sofia right now.

This is not strictly a cppyy problem. These tests fail (mostly) due to ABI changes:

2025-06-17T10:51:13.4434120Z ../../../../../../src/bindings/pyroot/cppyy/cppyy/test/test_datatypes.py::TestDATATYPES::test49_addressof_method input_line_276:2:104: error: call to non-static member function without an object argument
2025-06-17T10:51:13.4435240Z  (vector<int>::reference (*)(vector<int>::size_type))&std::__1::vector<int, std::__1::allocator<int>>::at[abi:ne200100]
2025-06-17T10:51:13.4435800Z                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
2025-06-17T10:51:13.4436300Z input_line_276:2:110: error: unexpected ':' in nested name specifier; did you mean '::'?
2025-06-17T10:51:13.4437000Z  (vector<int>::reference (*)(vector<int>::size_type))&std::__1::vector<int, std::__1::allocator<int>>::at[abi:ne200100]
2025-06-17T10:51:13.4437520Z                                                                                                              ^
2025-06-17T10:51:13.4438060Z                                                                                                              ::
2025-06-17T10:51:13.4438510Z input_line_276:2:111: error: no member named 'ne200100' in namespace '__cxxabiv1'
2025-06-17T10:51:13.4439160Z  (vector<int>::reference (*)(vector<int>::size_type))&std::__1::vector<int, std::__1::allocator<int>>::at[abi:ne200100]
2025-06-17T10:51:13.4439810Z                                                                                                           ~~~~^
2025-06-17T10:51:13.4440110Z FAILED
2025-06-17T10:51:20.1961970Z /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/unique_ptr.h:777:6: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Args'
2025-06-17T10:51:20.1963140Z void make_unique(_Args&&...) = delete;
2025-06-17T10:51:20.1963540Z      ^
2025-06-17T10:51:20.1964230Z input_line_132:11:70: error: address of overloaded function 'make_unique' does not match required type 'std::unique_ptr<int, std::default_delete<int> > ()'
2025-06-17T10:51:20.1965320Z       (void)(((std::unique_ptr<int, std::default_delete<int> > (&)())std::__1::make_unique<int, 0>)());
2025-06-17T10:51:20.1966010Z                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-06-17T10:51:20.1967070Z /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/unique_ptr.h:766:76: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Args'
2025-06-17T10:51:20.1968330Z inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX23 unique_ptr<_Tp> make_unique(_Args&&... __args) {
2025-06-17T10:51:20.1968970Z                                                                            ^
2025-06-17T10:51:20.1970000Z /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/unique_ptr.h:771:76: note: candidate template ignored: invalid explicitly-specified argument for 2nd template parameter
2025-06-17T10:51:20.1971220Z inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX23 unique_ptr<_Tp> make_unique(size_t __n) {
2025-06-17T10:51:20.1971840Z                                                                            ^
2025-06-17T10:51:20.1972870Z /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/v1/__memory/unique_ptr.h:777:6: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Args'
2025-06-17T10:51:20.1973900Z void make_unique(_Args&&...) = delete;
2025-06-17T10:51:20.1974250Z      ^
2025-06-17T10:51:20.1974570Z FAILED
2025-06-17T10:51:13.4483950Z         for i in range(len(names)):
2025-06-17T10:51:13.4484260Z >           setattr(c, 'm_'+names[i], i)
2025-06-17T10:51:13.4484610Z E           TypeError: C++ type cannot be converted to memory

and

2025-06-18T11:21:28.4712460Z >       assert cppyy.addressof(cppyy.gbl.std.vector[int].at.__overload__(':any:', False))
2025-06-18T11:21:28.4713180Z E       AssertionError: assert 0
2025-06-18T11:21:28.4713890Z E        +  where 0 = <built-in function addressof>(<cppyy.CPPOverload object at 0x10bc1d740>)
2025-06-18T11:21:28.4714920Z E        +    where <built-in function addressof> = <module 'cppyy' from '/Users/sftnight/ROOT-CI/build/lib/cppyy/__init__.py'>.addressof
2025-06-18T11:21:28.4716510Z E        +    and   <cppyy.CPPOverload object at 0x10bc1d740> = <built-in method __overload__ of cppyy.CPPOverload object at 0x10b498fc0>(':any:', False)
2025-06-18T11:21:28.4717960Z E        +      where <built-in method __overload__ of cppyy.CPPOverload object at 0x10b498fc0> = <cppyy.CPPOverload object at 0x10b498fc0>.__overload__
2025-06-18T11:21:28.4719250Z E        +        where <cppyy.CPPOverload object at 0x10b498fc0> = <class cppyy.gbl.std.vector<int> at 0x74dbdc810>.at

Currently these tests only fail on mac beta and pass on the stable SDKs on ARM. I believe we need to annotate mac-beta to OS X 26 in the pytest message, move ahead with this PR, and resolve these problems incrementally (some of which should be solved with updating the modules)

fails while compiling codegen from callfunc due to changes in libc++ (ABI)
@aaronj0 aaronj0 merged commit 8425a6b into root-project:master Jun 18, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants