[Math] Move gradient methods to IBaseFunction classes #19070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for tackling this! Besides the failing test, roofit/roofit/test/GaussFunction.h needs an override, too |
guitargeek
force-pushed
the
ifunction_gradient
branch
from
c6bbb9a to
5bc22e4
Compare
Test Results 18 files 18 suites 3d 10h 49m 14s ⏱️ Results for commit c657b8f. ♻️ This comment has been updated with latest results. |
Move the gradient-related methods from the `IGradientFunctionMultiDimTempl` to the `IBaseFunctionMultiDimTempl` base class, and the same for the 1D version. This makes the `IGradientFunction` classes pure "indicator" classes that indicate whether the gradient is implemented by the user or not. The actual function interface is unified in the IBaseFunctions. This fixes the problem that the override keywords could not be used consistently in I*Function-derived classes where the base class was templated to be either `IBaseFunction` or `IGradientFunction`.
guitargeek
force-pushed
the
ifunction_gradient
branch
from
5bc22e4 to
c657b8f
Compare
ferdymercury
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the gradient-related methods from the
IGradientFunctionMultiDimTemplto theIBaseFunctionMultiDimTemplbase class, and the same for the 1D version.This makes the
IGradientFunctionclasses pure "indicator" classes that indicate whether the gradient is implemented by the user or not. The actual function interface is unified in the IBaseFunctions.This fixes the problem that the override keywords could not be used consistently in I*Function-derived classes where the base class was templated to be either
IBaseFunctionorIGradientFunction.Alternative to: