Skip to content

Remove deprecated feedforward service from example 16 #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

astral-fi
Copy link

Removed set_feedforward_control from demo_test_helper.py
Removed Feedforward Service from the userdoc

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this!

Some comments in the code below. Do we need the demo_test_helper.py now? There is only a single twist command publisher left, I suggest removing this and updating the section (point 3 in Visualize the convergence of DiffBot's wheel velocities and commands), what do you think? or @Juliaj?

@astral-fi
Copy link
Author

@christophfroehlich Hey! Thank you for helping me out. I have made changes as per your suggestion. Please let me know if I messed up somewhere else.

@Juliaj
Copy link
Contributor

Juliaj commented Jun 24, 2025

Do we need the demo_test_helper.py now? There is only a single twist command publisher left, I suggest removing this and updating the section (point 3 in Visualize the convergence of DiffBot's wheel velocities and commands), what do you think? or @Juliaj?

Let's remove demo_test_helper.py as its remaining logic is minimal, and the file is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants