[JTC] Remove deprecated open_loop_control code

[Thieso]

Follow up on #1525.

Is this sufficient or should I add a note somewhere (release notes or something)?.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (ac35696) to head (0a5020a).
Report is 26 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   85.08%   85.15%   +0.07%     
==========================================
  Files         123      123              
  Lines       11703    11696       -7     
  Branches      999      994       -5     
==========================================
+ Hits         9957     9960       +3     
+ Misses       1430     1427       -3     
+ Partials      316      309       -7     

Flag	Coverage Δ
unittests	85.15% <100.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp	85.99% <100.00%> (+0.35%)	⬆️
...ntroller/test/test_trajectory_controller_utils.hpp	84.32% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[christophfroehlich]

Thanks for the follow-up.

You could just add this PR to the release notes in the same bullet point of #1525, but the text is already good as it is.

[christophfroehlich]

the downstream ur_controllerspackage fails now.

   Starting >>> ur_controllers
  --- stderr: ur_controllers
  /home/runner/work/ros2_controllers/ros2_controllers/.work/downstream_ws/src/UniversalRobots/Universal_Robots_ROS2_Driver/ur_controllers/src/scaled_joint_trajectory_controller.cpp: In member function ‘virtual controller_interface::return_type ur_controllers::ScaledJointTrajectoryController::update(const rclcpp::Time&, const rclcpp::Duration&)’:
  /home/runner/work/ros2_controllers/ros2_controllers/.work/downstream_ws/src/UniversalRobots/Universal_Robots_ROS2_Driver/ur_controllers/src/scaled_joint_trajectory_controller.cpp:171:19: error: ‘struct joint_trajectory_controller::Params’ has no member named ‘open_loop_control’
    171 |       if (params_.open_loop_control) {

@Thieso are you working with UR robots? If not, I can open a PR there once we merge this here.

[Thieso]

@Thieso are you working with UR robots? If not, I can open a PR there once we merge this here.

No I am not. Only kinova right now.