[JTC] Hold the position after the goal was reached successfully #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2023
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
christophfroehlich
force-pushed
the
jtc_hold_on_action_success
branch
from
7e1bf7f to
c8cf278
Compare
|
merged into #558 |
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 3, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JTC with command interface
velocity: As described in #469, JTC does not stop if last velocity point is not zero.I propose calling
set_hold_positionif the goal was successfully reached.Optional rejection of nonzero velocity is proposed with #567