Fix building on CentOS 9 #2231
Merged
Fix building on CentOS 9 #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Apr 8, 2025
`CMAKE_POLICY(SET CMP0148 OLD)` fails on CMake < 3.27, when CMP0148 was introduced. Centos 9 Stream is still on CMake 3.26. On CMake >= 3.27, this change adds back a warning that "Policy CMP0148 is not set". [1] https://cmake.org/cmake/help/latest/command/cmake_policy.html#setting-policies-by-cmake-version
evan-goode
force-pushed
the
evan-goode/fix-cmake
branch
from
e39c865 to
7602cec
Compare
ppisar
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Now it warns:
Manually-specified variables were not used by the project:
BUILD_SHARED_LIBS
CMAKE_CXX_FLAGS_RELEASE
CMAKE_C_FLAGS_RELEASE
CMAKE_Fortran_FLAGS_RELEASE
CMAKE_INSTALL_DO_STRIP
CMAKE_INSTALL_FULL_SBINDIR
CMAKE_INSTALL_SBINDIR
CMAKE_POLICY_VERSION_MINIMUM
But I believe this is harmless because this project does not compile any binary executables. I will approve this pull request after finishing at least one ci-dnf-stack task.
ppisar
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building from the master branch on RHEL 9/CentOS 9 has been broken since #2217. This means that our nightly Copr has been broken for el9.
CMAKE_POLICY(SET CMP0148 OLD)fails on CMake < 3.27, when CMP0148 was introduced. Centos 9 Stream is still on CMake 3.26.Changing this to a
CMAKE_POLICY(VERSION ...)command is generally recommended [1] over setting policies individually, but this change does add back a warning that "Policy CMP0148 is not set".[1] https://cmake.org/cmake/help/latest/command/cmake_policy.html#setting-policies-by-cmake-version