search: Do not separate a package from a summary with a colon #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reported that selecting a package name from an output of "dnf5
search" command was difficult because of a colon adjacent to the
pacakge name:
$ dnf5 search dontpanic
Updating and loading repositories:
Repositories loaded.
Matched fields: name (exact)
dontpanic.i686: Very simple library and executable used in testing Alien::Base
Double-clicking on "dontpanic" word selected "dontpanic.i686:",
including the colon character. That made dificult to copy and paste
the found packages.
While this is a problem of the terminal emulator and later the reporter
found a setttings of his terminal not to do it, I think we should use
a pure white-space separator to help people with not so advanced
terminals.
This patch replaces the ": " separator with a single tabulation
character:
$ dnf5 search dontpanic
Updating and loading repositories:
Repositories loaded.
Matched fields: name (exact)
dontpanic.i686 Very simple library and executable used in testing Alien::Base
Resolves rpm-software-management#2166
|
Yeah, I think we can change it this way. Will you prepare a patch that adjusts the tests? It affects dnf-behave-tests/dnf/search.feature and dnf-behave-tests/dnf/search-sort.feature . |
|
I will prepare a patch for the tests. |
ppisar
added a commit
to ppisar/ci-dnf-stack
that referenced
this pull request
Apr 10, 2025
|
We can merge this but note there is a community PR already that changes the search output to use libsmartcols: #2180. That PR would also need accompanying changes to ci-dnf-stack. |
ppisar
added a commit
to ppisar/ci-dnf-stack
that referenced
this pull request
Apr 10, 2025
Implemenation detail: Bahave does not expand escape sequences in multi-line texts associated with a step. Hence this patch uses literal tabulation characters (U+0009) instead of "\t" sequences. For: rpm-software-management/dnf5#2190 Resolves: rpm-software-management/dnf5#2166
|
If the smartcols-formatted output is what we want, then this pull request should not be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that selecting a package name from an output of "dnf5 search" command was difficult because of a colon adjacent to the pacakge name:
Double-clicking on "dontpanic" word selected "dontpanic.i686:", including the colon character. That made dificult to copy and paste the found packages.
While this is a problem of the terminal emulator and later the reporter found a setttings of his terminal not to do it, I think we should use a pure white-space separator to help people with not so advanced terminals.
This patch replaces the ": " separator with a single tabulation character:
Resolves #2166
Do we want this change?
I guess we will need to adjust dnf-behave-tests/dnf/search.feature which again matches output literally.