Expose arch
in Python bindings
#92
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #91 for the rationale. I ended up doing that myself anyways (partially, as
<group arch="..."
and<groupid arch="..."
are yet to be implemented).Notes:
NULL
fromcomps_docpackage_arches
toNone
. But tracking what else could dereference((PyCOMPS_Sequence*)self)->list
when it's set toNULL
is a pain.The only viable alternative, IMO, is to init arches in comps_docpackage to an empty list when it's requested from the python bindings. Let me know which approach is preferred.
__PyCOMPS_set_arches
lacks conversion fromlist[str]
. Pretty sure I've seen the code for that in one of the source files (__pycomps_strlist_in
?), but extracting and applying it may be a bit of a pain.libcomps.StrSeq
here? If it's the right approach, I'd prefer to also move it to a separate header+source along with get/set/conversion helpers.Fixes #91