module: Warn if module config file is inaccessible #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, we need to distinguish between a missing config file and one that exists but is unreadable (e.g., due to insufficient permissions). This patch introduces a new FileDoesNotExist exception class, which is a more specific subclass of the existing CantOpenFile class. This ensures that any existing workflows remain unaffected.
If a DNF module configuration file is unreadable, `dnf` may return unexpected results without warning the user, potentially affecting command output. Steps to reproduce: 1. Enable the `nginx` module as root with a restrictive `umask`, making the config file unreadable for normal users: # umask 0066 # dnf module enable nginx:1.24 # ls -l /etc/dnf/modules.d/nginx.module -rw-------. 1 root root 55 Oct 16 09:59 /etc/dnf/modules.d/nginx.module 2. Check available packages as root (CORRECT): # dnf list --available nginx [...] Available Packages nginx.x86_64 1:1.24.0-1.module+el9.4.0+21950+8ebc21e2.1 3. Check available packages as a normal user (INCORRECT): $ dnf list --available nginx [...] Available Packages nginx.x86_64 1:1.20.1-16.el9_4.1 This patch introduces a warning when a module config file exists but is inaccessible, helping users diagnose potential issues: $ dnf list --available nginx [...] Cannot read "/etc/dnf/modules.d/nginx.module". Modular filtering may be affected. Available Packages nginx.x86_64 1:1.20.1-16.el9_4.1 Resolves: https://issues.redhat.com/browse/RHEL-62833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module: Warn if module config file is inaccessible
If a DNF module configuration file is unreadable,
dnfmay return unexpected results without warning the user, potentially affecting command output.Steps to reproduce:
nginxmodule as root with a restrictiveumask, making the config file unreadable for normal users:This patch introduces a warning when a module config file exists but is inaccessible, helping users diagnose potential issues:
Resolves: https://issues.redhat.com/browse/RHEL-62833
Test: rpm-software-management/ci-dnf-stack#1628