FilesCheck: Don't fail with mtime in pyc > py #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danigm
force-pushed
the
fix-pyc-mtime-check
branch
from
7f4fbec to
2fafafd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
danigm
force-pushed
the
fix-pyc-mtime-check
branch
2 times, most recently
from
238eb38 to
96c3ac6
Compare
This patch changes the python-bytecode-inconsistent-mtime to do not show if the pyc mtime is later than the source. We are seeing a lot of false positive errors like this building locally with OBS and this will fix the issue. See https://bugzilla.suse.com/show_bug.cgi?id=1240894
danigm
force-pushed
the
fix-pyc-mtime-check
branch
from
96c3ac6 to
845d4ab
Compare
|
I'm not sure if this is the correct fix. Looks like cpython is checking that the dates are exactly the same, so if we modify this check we can pass packages that will be "wrong" and the interpreter will recreate .pyc files on first import / run. https://github.com/python/cpython/blob/main/Lib/compileall.py#L236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the python-bytecode-inconsistent-mtime to do not show if the pyc mtime is later than the source. We are seeing a lot of false positive errors like this building locally with OBS and this will fix the issue.
See https://bugzilla.suse.com/show_bug.cgi?id=1240894