11191 move ue context #23

rsarwad · 2022-08-02T10:25:32Z

Modified code to replace C structure ue_description_t to protobuf structure UeDescription

Summary

Modified code to replace C structure ue_description_t to protobuf structure UeDescription

Test Plan

Tested both unit test cases and end2end test cases with s1ap sanity test suite

…tobuf structure, UeDescription in s1ap module Signed-off-by: Rashmi <[email protected]>

from s1ap_types.hpp Signed-off-by: Rashmi <[email protected]>

github-actions · 2022-08-02T10:25:49Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-08-02T10:26:38Z

❌ The Semantic PR check ended with status failure. See instructions on formatting your commit and pull request titles.

github-actions · 2022-08-02T10:27:58Z

lte/gateway/c/core/oai/tasks/s1ap/s1ap_state.cpp

                                     void* parameterP, void** resultP) {
  mme_ue_s1ap_id_t* mme_ue_s1ap_id_p = (mme_ue_s1ap_id_t*)parameterP;
-  ue_description_t* ue_ref = (ue_description_t*)elementP;
-  if (*mme_ue_s1ap_id_p == ue_ref->mme_ue_s1ap_id) {
+  UeDescription* ue_ref = (UeDescription*)elementP;


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<UeDescription*>(...) instead [readability/casting] [4]

github-actions · 2022-08-02T10:27:58Z

lte/gateway/c/core/oai/tasks/s1ap/s1ap_state.cpp

                             void* parameterP, void** resultP) {
  imsi64_t imsi64 = INVALID_IMSI64;
  imsi64_t* target_imsi64 = (imsi64_t*)parameterP;
-  ue_description_t* ue_ref = (ue_description_t*)elementP;
+  UeDescription* ue_ref = (UeDescription*)elementP;


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<UeDescription*>(...) instead [readability/casting] [4]

Signed-off-by: Rashmi <[email protected]>

* chore(agw): Clean up unnecessary Make commands: build_c and test_c Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: clang_tidy_oai and clang_tidy_oai_upload Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: build_oai_clang and clang_warning_oai_upload Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: help Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: log, logs and status Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: precommit_sm and precommit_oai Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: scan_oai Signed-off-by: Lars Kreutzer <[email protected]> * chore(agw): Clean up unnecessary Make commands: smf_build Signed-off-by: Lars Kreutzer <[email protected]> Signed-off-by: Lars Kreutzer <[email protected]>

Signed-off-by: Rashmi <[email protected]>

Modified code to replace hashtable with protobuf map for state_ue hash table in s1ap module

Signed-off-by: Sebastian Thomas <[email protected]>

Signed-off-by: Rashmi <[email protected]>

github-actions · 2022-09-02T09:32:45Z

dp/cloud/docker/python/configuration_controller/Dockerfile

@@ -1,7 +1,7 @@
 ARG ENV=standard
 FROM python:3.9.2-slim-buster as protos-generator

-RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
+RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2022-09-02T09:32:45Z

dp/cloud/docker/python/radio_controller/Dockerfile

@@ -1,7 +1,7 @@
 ARG ENV=standard
 FROM python:3.9.2-slim-buster as protos-generator

-RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
+RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2022-09-02T09:32:46Z

dp/cloud/docker/python/test_runner/Dockerfile

@@ -1,7 +1,7 @@
 ARG ENV=standard
 FROM python:3.9.2-slim-buster as protos-generator

-RUN apt-get update && apt-get install -y --no-install-recommends curl=7.64.0-4+deb10u2 zip=3.0-11+b1 make=4.2.1-1.2 unzip=6.0-23+deb10u2
+RUN apt-get update && apt-get install -y --no-install-recommends curl zip make unzip


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2022-09-02T09:33:05Z

lte/gateway/docker/docker-compose.dev.yaml

+    environment:
+      - MAGMA_DEV_MODE=1
+
+  monitord:


[misspell] _{reported by reviewdog 🐶}
"monitord" is a misspelling of "monitored"

github-actions · 2022-09-02T09:33:10Z

orc8r/cloud/go/services/obsidian/swagger/v1/swagger.yml

+  /dp/{network_id}/cbsds/{cbsd_id}/relinquish:
+    post:
+      parameters:
+      - $ref: '#/parameters/network_id'


[yamllint] _{reported by reviewdog 🐶}
[error] wrong indentation: expected 8 but found 6 (indentation)

github-actions · 2022-09-02T09:33:10Z

orc8r/cloud/go/services/obsidian/swagger/v1/swagger.yml

+          $ref: '#/responses/UnexpectedError'
+      summary: Force relinquish all grants in SAS of given CBSD
+      tags:
+      - cbsds


[yamllint] _{reported by reviewdog 🐶}
[error] wrong indentation: expected 8 but found 6 (indentation)

Signed-off-by: Rashmi <[email protected]>

…ow (magma#13803) Signed-off-by: Lars Kreutzer <[email protected]> Co-authored-by: Lars Kreutzer [email protected] Co-authored-by: Krisztián Varga [email protected] Signed-off-by: Lars Kreutzer <[email protected]>

… for feg and systemd magmad for agw. So the detection fails. (magma#13781) Signed-off-by: Christian Krämer <[email protected]> Signed-off-by: Christian Krämer <[email protected]>

* feat(agw): envoy controller is dockerized Signed-off-by: Christian Krämer <[email protected]> * feat(agw): envoy namespace is now configured by the envoy service Signed-off-by: Christian Krämer <[email protected]> * feat(agw): install dhclient in pipelined container Signed-off-by: Sebastian Wolf <[email protected]> Signed-off-by: Christian Krämer <[email protected]> Signed-off-by: Sebastian Wolf <[email protected]> Co-authored-by: Christian Krämer <[email protected]> Co-authored-by: Marco Pfirrmann <[email protected]>

) * feat(agw): restart functions can now handle docker containers and systemd services Signed-off-by: Marco Pfirrmann <[email protected]> * feat(agw): handling of redis states is improved Signed-off-by: Marco Pfirrmann <[email protected]> * feat(agw): cleanup redis if not empty Signed-off-by: Marco Pfirrmann <[email protected]> * feat(agw): service restart is adapted to new syntax Signed-off-by: Marco Pfirrmann <[email protected]> Signed-off-by: Marco Pfirrmann <[email protected]>

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]>

* feat(dp): Implement GetState in DP orc8r service Signed-off-by: Wojciech Sadowy <[email protected]> * fixes Signed-off-by: Wojciech Sadowy <[email protected]> * adding test with more cbsds and grants Signed-off-by: Wojciech Sadowy <[email protected]> * fixes after rebase Signed-off-by: Wojciech Sadowy <[email protected]> Signed-off-by: Wojciech Sadowy <[email protected]> Co-authored-by: Wojciech Sadowy <[email protected]>

Signed-off-by: Jan Heidbrink <[email protected]>

Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]>

Previously AMC used additional grpc service to communicate with the database, but it was inefficient. Signed-off-by: Kuba Marciniszyn <[email protected]> Signed-off-by: Kuba Marciniszyn <[email protected]>

…plate (magma#13934) Signed-off-by: Tomasz Gromowski <[email protected]>

Signed-off-by: Oleksandr Berezovskyi <[email protected]> Signed-off-by: Oleksandr Berezovskyi <[email protected]>

…13890) Signed-off-by: Kuba Marciniszyn <[email protected]> Signed-off-by: Kuba Marciniszyn <[email protected]>

Signed-off-by: Wojciech Sadowy <[email protected]> Signed-off-by: Wojciech Sadowy <[email protected]> Co-authored-by: Wojciech Sadowy <[email protected]>

* test(cwag): Modified quotas - Make `TestGyCreditExhaustionRedirect` more stable by reducing the quota and the requested data volume. - Larger data requests are more likely to fail. - test(cwag): Reformatted comments

Sort all installed packages alphabetically, remove duplicates, and add explicit cleanup after installing Signed-off-by: Sebastian Wolf <[email protected]> Signed-off-by: Sebastian Wolf <[email protected]>

Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <[email protected]>

Signed-off-by: Jan Heidbrink <[email protected]>

* chore(ci): Add a new CI workflow for running integ tests against magma debian installation Signed-off-by: Alex Jahl <[email protected]> * chore(ci): Improve comparison with None Signed-off-by: Cameron Voisey <[email protected]> Signed-off-by: Alex Jahl <[email protected]> Signed-off-by: Cameron Voisey <[email protected]> Co-authored-by: Cameron Voisey <[email protected]>

…13917) * fix(nms): Improve sync of NMS organizations and orc8r tenants - Sync all changes of NMS organization to orc8rs - Add documentation that orc8r tenant API should not be used to modify tenants - Fix wrong description in NMS organization edit dialog Signed-off-by: Sebastian Thomas <[email protected]> * fix(nms): Improve sync of NMS organizations and orc8r tenants - Sync all changes of NMS organization to orc8rs - Add documentation that orc8r tenant API should not be used to modify tenants - Fix wrong description in NMS organization edit dialog Signed-off-by: Sebastian Thomas <[email protected]>

* fix(agw): the envoy controller is in the feg image Signed-off-by: Fritz Lehnert <[email protected]> * fix(agw): only 1 go service does not need abstraction Signed-off-by: Fritz Lehnert <[email protected]>

Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

…gma#13960) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

Signed-off-by: Marco Pfirrmann <[email protected]>

…p/hpp and also removed unused structure, deactivated_predefined_pcc_rules (magma#13943) Signed-off-by: Rashmi <[email protected]>

* feat(amf): Support for Protocol Configuration Options IE Signed-off-by: sreedharkumartn <[email protected]> * Addressed Review Comments (R1) Signed-off-by: sreedharkumartn <[email protected]> * Addressed Review Comments (R2) Signed-off-by: sreedharkumartn <[email protected]> Signed-off-by: sreedharkumartn <[email protected]>

…a#13957) Signed-off-by: Marco Pfirrmann <[email protected]>

…text Signed-off-by: Rashmi <[email protected]>

github-actions · 2022-09-20T11:11:34Z

lte/gateway/python/BUILD.bazel

+    "health",
+    "kernsnoopd",
+    "mobilityd",
+    "monitord",


[misspell] _{reported by reviewdog 🐶}
"monitord" is a misspelling of "monitored"

Signed-off-by: Rashmi <[email protected]>

rsarwad added 2 commits July 25, 2022 12:47

agw(fix): coverted C structure of ue context, ue_description_t to pro…

42719e6

…tobuf structure, UeDescription in s1ap module Signed-off-by: Rashmi <[email protected]>

Defined S1ap UE state in proto file and removed the enum definition

a3b791b

from s1ap_types.hpp Signed-off-by: Rashmi <[email protected]>

github-actions bot added the component: agw label Aug 2, 2022

github-actions bot reviewed Aug 2, 2022

View reviewed changes

rsarwad force-pushed the 11191_move_ue_context branch 2 times, most recently from f274d37 to d7925b0 Compare August 4, 2022 07:01

Resolved merge conflicts

fafd30f

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11191_move_ue_context branch from d7925b0 to fafd30f Compare August 4, 2022 09:51

rsarwad force-pushed the rsarwad_migrate_state_ue_ht_s1ap branch from 4d2837d to 68afe56 Compare August 4, 2022 13:59

rsarwad added 2 commits August 22, 2022 13:16

Resolved merge conflicts

ecea04c

Signed-off-by: Rashmi <[email protected]>

Updating s1ap_state.pb.go file

bf7e827

Signed-off-by: Rashmi <[email protected]>

github-actions bot added the component: orc8r label Aug 22, 2022

rsarwad and others added 6 commits August 30, 2022 20:16

Addressed self review comments

4f960ca

Signed-off-by: Rashmi <[email protected]>

Addressed review comments

ccc7293

Signed-off-by: Rashmi <[email protected]>

fix(agw): Migrate hash list of state_ue to protobuf_map (magma#13508)

b9bf710

Modified code to replace hashtable with protobuf map for state_ue hash table in s1ap module

fix(agw): Fix spyne version in pydep lockfile (magma#13809)

e2e032c

Signed-off-by: Sebastian Thomas <[email protected]>

Resolved merge conflicts

2ed0912

Signed-off-by: Rashmi <[email protected]>

github-actions bot added component: ci and removed component: agw component: orc8r labels Sep 2, 2022

github-actions bot reviewed Sep 2, 2022

View reviewed changes

Addressed self comments

9c6abcf

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11191_move_ue_context branch from 441db76 to 9c6abcf Compare September 2, 2022 12:01

LKreutzer and others added 2 commits September 2, 2022 13:23

fix(ci): Fix feg integ tests. Feg integ tests need both docker magmad…

4134ee9

… for feg and systemd magmad for agw. So the detection fails. (magma#13781) Signed-off-by: Christian Krämer <[email protected]> Signed-off-by: Christian Krämer <[email protected]>

wolfseb and others added 26 commits September 15, 2022 09:55

chore(dp): WithinTx should not suppress panic (magma#13933)

1212843

Signed-off-by: Jarosław Jaszczuk <[email protected]> Signed-off-by: Jarosław Jaszczuk <[email protected]>

chore(dp): Get rid of legacy active-mode controller (magma#13906)

11896c1

Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]>

docs(agw): Mark the AGWC Helm chart as experimental (magma#13920)

f042921

Signed-off-by: Jan Heidbrink <[email protected]>

chore(dp): Fix domain-proxy build job (magma#13937)

3356cb0

Signed-off-by: Tomasz Gromowski <[email protected]> Signed-off-by: Tomasz Gromowski <[email protected]>

feat(dp): Use database directly in AMC (magma#13930)

e718514

Previously AMC used additional grpc service to communicate with the database, but it was inefficient. Signed-off-by: Kuba Marciniszyn <[email protected]> Signed-off-by: Kuba Marciniszyn <[email protected]>

chore(orc8r): Add missing dp enabled parameter to terraform input tem…

0118afd

…plate (magma#13934) Signed-off-by: Tomasz Gromowski <[email protected]>

fix(agw): perform install of magma runtime dependencies (magma#13924)

9755fdf

Signed-off-by: Oleksandr Berezovskyi <[email protected]> Signed-off-by: Oleksandr Berezovskyi <[email protected]>

chore(dp): Preallocate memory when collecting column pointers (magma#…

0e293ef

…13890) Signed-off-by: Kuba Marciniszyn <[email protected]> Signed-off-by: Kuba Marciniszyn <[email protected]>

chore(dp): supressed radio controller operation (magma#13925)

b8ad056

Signed-off-by: Wojciech Sadowy <[email protected]> Signed-off-by: Wojciech Sadowy <[email protected]> Co-authored-by: Wojciech Sadowy <[email protected]>

test(cwg): Stabilizing TestGyCreditExhaustionRedirect (magma#13870)

8dc6dea

* test(cwag): Modified quotas - Make `TestGyCreditExhaustionRedirect` more stable by reducing the quota and the requested data volume. - Larger data requests are more likely to fail. - test(cwag): Reformatted comments

chore(agw): cleanup apt installs in agw Dockerfiles (magma#13932)

4299e29

Sort all installed packages alphabetically, remove duplicates, and add explicit cleanup after installing Signed-off-by: Sebastian Wolf <[email protected]> Signed-off-by: Sebastian Wolf <[email protected]>

fix(agw): Downgrade grpcio to fix pylint (magma#13946)

1d34f11

Downgrade grpcio in - setup.py - build script - bazel setup Signed-off-by: Sebastian Thomas <[email protected]>

fix(ci): Add missing paths to path filter (magma#13959)

f6f1d00

Signed-off-by: Jan Heidbrink <[email protected]>

fix(agw): the envoy controller is in the feg image (magma#13947)

e111d5a

* fix(agw): the envoy controller is in the feg image Signed-off-by: Fritz Lehnert <[email protected]> * fix(agw): only 1 go service does not need abstraction Signed-off-by: Fritz Lehnert <[email protected]>

chore: magma#11633 is reverted manually (magma#13868)

5a26549

Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

fix: py cryptography is pinned to a version that works with magma (ma…

c89642a

…gma#13960) Signed-off-by: Nils Semmelrock <[email protected]> Signed-off-by: Nils Semmelrock <[email protected]>

feat(agw): all AGW containeres have health checks (magma#13918)

dc69a34

Signed-off-by: Marco Pfirrmann <[email protected]>

fix(agw): Modified code to remove unused files, pgw_pcef_emulation.cp…

3ab0f9d

…p/hpp and also removed unused structure, deactivated_predefined_pcc_rules (magma#13943) Signed-off-by: Rashmi <[email protected]>

fix(agw): Pin version of grpcio_tool in python_dev ansible role (magm…

a9c2f01

…a#13957) Signed-off-by: Marco Pfirrmann <[email protected]>

Merge remote-tracking branch 'upstream/master' into 11191_move_ue_con…

8f7d260

…text Signed-off-by: Rashmi <[email protected]>

github-actions bot reviewed Sep 20, 2022

View reviewed changes

rsarwad force-pushed the 11191_move_ue_context branch from 9bafb19 to 555307b Compare September 20, 2022 14:56

Addressed review comments

59c836c

Signed-off-by: Rashmi <[email protected]>

rsarwad force-pushed the 11191_move_ue_context branch from 555307b to 59c836c Compare September 20, 2022 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

11191 move ue context #23

11191 move ue context #23

rsarwad commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022 •

edited

Loading

github-actions bot Aug 2, 2022

github-actions bot Aug 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 2, 2022

github-actions bot Sep 20, 2022

11191 move ue context #23

Are you sure you want to change the base?

11191 move ue context #23

Conversation

rsarwad commented Aug 2, 2022

Summary

Test Plan

github-actions bot commented Aug 2, 2022

Howto

More info

github-actions bot commented Aug 2, 2022 • edited Loading

github-actions bot Aug 2, 2022

Choose a reason for hiding this comment

github-actions bot Aug 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 20, 2022

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2022 •

edited

Loading