Skip to content

update depencies & manage consequences & update readme & add grid_map to lib.rs & add dijkstra motion planning #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2024
Merged

update depencies & manage consequences & update readme & add grid_map to lib.rs & add dijkstra motion planning #3

merged 3 commits into from
Mar 22, 2024

Conversation

SalahEddineGhamri
Copy link
Contributor

@SalahEddineGhamri SalahEddineGhamri commented Mar 9, 2024 •
edited
Loading

  • This pull request is about updating dependencies to the latest versions.
  • The consequences are mainly in ekf.rs a little change to how Normal distribution is created.
  • Readme is also updated for staenely_controller.rs

Note
Other changes are just trimmed spaces inflected by my editor.

This pull request includes answers #4

@SalahEddineGhamri SalahEddineGhamri changed the title update depencies & manage consequences & update readme update depencies & manage consequences & update readme & add grid_map to lib.rs Mar 10, 2024
@SalahEddineGhamri SalahEddineGhamri force-pushed the main branch 2 times, most recently from f991554 to 31f386f Compare March 17, 2024 16:46
@SalahEddineGhamri
Copy link
Contributor Author

added dijkstra algorithm with some read me enhancements

@rsasaki0109
Copy link
Owner

rsasaki0109 commented Mar 18, 2024 •
edited
Loading

Sorry, I didn't notice because there was an issue with my notifications.
Thank you for the wonderful PR!

Is it okay if I review this and merge it if there are no issues?

@rsasaki0109 rsasaki0109 self-requested a review March 18, 2024 06:30
@rsasaki0109 rsasaki0109 added the enhancement New feature or request label Mar 18, 2024
@SalahEddineGhamri
Copy link
Contributor Author

SalahEddineGhamri commented Mar 18, 2024 •
edited
Loading

The Dijkstra works but still lacks a "heap" which will remove the linear search for shortest distance as it removes complexity. What do you think? We wait for the heap or we proceed like this ?

@rsasaki0109
Copy link
Owner

rsasaki0109 commented Mar 18, 2024 •
edited
Loading

Thank you for checking! Since time isn’t pressing on my end, I think waiting for the heap implementation to enhance the algorithm's efficiency is the way to go. Of course, it also hinges on your schedule.

@SalahEddineGhamri
Copy link
Contributor Author

Thank you for checking! Since time isn’t pressing on my end, I think waiting for the heap implementation to enhance the algorithm's efficiency is the way to go. Of course, it also hinges on your schedule.

Yes, i will modify it.

@SalahEddineGhamri SalahEddineGhamri force-pushed the main branch 2 times, most recently from dbc62a8 to 2528660 Compare March 20, 2024 00:19
@SalahEddineGhamri SalahEddineGhamri changed the title update depencies & manage consequences & update readme & add grid_map to lib.rs update depencies & manage consequences & update readme & add grid_map to lib.rs & add dijkstra motion planning Mar 20, 2024
@SalahEddineGhamri
Copy link
Contributor Author

@rsasaki0109 I have made the necessary changes. Can you review it please ?

SalahEddineGhamri
SalahEddineGhamri commented Mar 20, 2024
View reviewed changes
img/dijkstra_planner.svg Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsasaki0109 I have already opened an issue about this in RustGnuplot repo. let's see what will be the solution.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo
SiegeLord/RustGnuplot#97

rsasaki0109
rsasaki0109 requested changes Mar 20, 2024
View reviewed changes
Copy link
Owner

@rsasaki0109 rsasaki0109 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SalahEddineGhamri
I have completed the review, so please check it out.

@SalahEddineGhamri
adding dijkstra motion planner
b01ba63 
working lazy dijkstra

working dijkstra planner

adding gif for dijkstra

using heap instead of search min

Update README.md
@SalahEddineGhamri
Copy link
Contributor Author

@SalahEddineGhamri I have completed the review, so please check it out.

@rsasaki0109 thank you for the valuable review notes. I have adopted them.

@rsasaki0109 rsasaki0109 merged commit d18fe72 into rsasaki0109:main Mar 22, 2024
@rsasaki0109
Copy link
Owner

Thank you for the changes! I've merged the pull request!

As soon as there is a response regarding 'RustGnuplot,' let's make the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsasaki0109 rsasaki0109 rsasaki0109 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SalahEddineGhamri @rsasaki0109