Drop ruby-head from test matrix to keep builds stable #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LeFnord
reviewed
May 23, 2025
| @@ -28,7 +28,7 @@ jobs: | |||
| needs: ['rubocop'] | |||
| strategy: | |||
| matrix: | |||
| ruby-version: ['3.0', '3.1', '3.2', '3.3', 'head'] | |||
| ruby-version: ['3.0', '3.1', '3.2', '3.3', '3.4'] | |||
There was a problem hiding this comment.
remove 3.0, as you mentioned in the description, and maybe replacing head by 3.5-dev
There was a problem hiding this comment.
We currently have 3.0 as a requirement in the gemspec.
What if I just change the PR description for now. And add 3.5-dev with ruby-head in a separate pull request where we can focus on supporting exactly 3.5?
dblock
approved these changes
May 24, 2025
|
Merging this, thanks for fixing CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trims the workflow by dropping the ruby-head test jobs. The ruby-head build is flaky right now, so it hides real regressions and slows CI without any help. Until Ruby 3.5 is out (or close to that point), we'll run only the stable 3.0-3.4 releases; 3.5 will be added in a separate PR. No runtime code change - just faster, greener builds.