Skip to content

Add ToB Death Sound Plugin #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Add ToB Death Sound Plugin #7887

wants to merge 25 commits into from

Conversation

nicellenburg
Copy link

Adds the ToB Death Sound plugin: plays a sound when a player dies in Theatre of Blood.
I'm very new to this process and open to any feedback.
Plugin repo: https://github.com/nicellenburg/tobdeathsound

@nicellenburg
Add ToB Death Sound
d1ad3ab 
Casual plugin that makes a custom sound whenever the player or a teammate dies within Theatre of Blood.

Currently the plugin only has 3 custom sounds, one being an inside joke amongst friends.

I'm very new to coding so if there's a lot of mistakes, I apologize!!!!
@nicellenburg
Force add ToB Death Sound plugin
7680c15
@nicellenburg
Add ToB Death Sound plugin
2dd3e61 
Adds a plugin that plays a custom sound when a nearby player dies during the Theatre of Blood raid.

- Works only inside ToB (region ID check)
- Includes volume slider, enable/disable toggle, and sound selector
- Sounds included: sitstella.wav, zerk.wav, sports.wav

Author: Nic
@nicellenburg
Updated Tob Death Sounds
9b1fe98 
Changed file names to be read by CI, apologies for the redundancy
@nicellenburg
Updated Tob Death Sounds 02
be17580 
Updated again to previous file extensions with decapitalization
@nicellenburg
Update 03
19bd6e5 
Once again updating file names for CI
@nicellenburg
Fix plugin filenames and metadata
e286ef1
@nicellenburg
Initial plugin setup with working ToB Death Sound code
dd9ef6e 
New commit in my own Repo
@nicellenburg
Add Tob Death Sounds Plugin Fixes
5a5ecf8 
CI and syntax fixes
@nicellenburg
Add ToB Death Sound Plugin
46fc9b6 
Hopefully I did this right, got a really bad case of covid right now so feeling a little foggy so apologies in advance for any bulk of mistakes
@nicellenburg
Merge branch 'master' of https://github.com/nicellenburg/plugin-hub
33b40e6
@nicellenburg
Add ToB Death Sounds Plugin
21ba370
@iProdigy
Copy link
Member

Please avoid closing/recreating PRs; simply keep pushing to a single PR.

Also your submission does not adhere to the described format in https://github.com/runelite/plugin-hub?tab=readme-ov-file#submitting-a-plugin as was pointed out in #7877 (comment)

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 24, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 24, 2025
@runelite-github-app
Copy link

runelite-github-app bot commented Apr 24, 2025 •
edited
Loading

New plugin tobdeathsound: https://github.com/nicellenburg/tobdeathsounds/tree/943d36013b4bc65a30b8b81bc8122741cc5a6150

@iProdigy
Copy link
Member

Your repo structure is also invalid; I'd recommend emulating https://github.com/runelite/example-plugin/

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 24, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 24, 2025
@runelite-github-app
Copy link

runelite-github-app bot commented Apr 24, 2025 •
edited
Loading

Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Contributor

Use AudioPlayer instead of managing clips yourself

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 26, 2025
@nicellenburg
Add ToB Death Sounds Plugin
6eb80b6 
Using AudioPlayer rather than Clip
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 26, 2025
@nicellenburg
Add ToB Death Sounds Plugin
5dc97bb 
Added 'runelite-client' in dependencies
@nicellenburg
Add ToB Death Sounds Plugin
d79957d 
reversed dependencies change
@nicellenburg
Add ToB Death Sounds Plugin
8365f75
@LlemonDuck
Copy link
Contributor

You did not make the changes I requested in my last comment

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 29, 2025
@nicellenburg
Copy link
Author

You did not make the changes I requested in my last comment

I initially tried using AudioPlayer, but the build failed with "cannot find symbol: AudioPlayer." Please advise if there's a recommended way to access it, or if the direct AudioSystem method is acceptable instead.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 29, 2025
@LlemonDuck
Copy link
Contributor

Make sure you refresh your dependencies locally to ensure you have the most recent version of RuneLite. gradlew build --refresh-dependencies. It's in the net.runelite.client.audio package.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 30, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 30, 2025
@nicellenburg
Copy link
Author

Sorry about my confusion there, I'm really new to this and I have one friend helping me out in making this as a fun project.
Thank you for your patience in all this! <3

@LlemonDuck
Copy link
Contributor

Where are the sound files sourced from?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 3, 2025
@nicellenburg
Copy link
Author

Where are the sound files sourced from?

2 sound files are from FreeTTS.com & 1 file is from friends band (permissions given). If that's still an issue I can swap it out for a TTS file as well

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 4, 2025
@LlemonDuck
Copy link
Contributor

freetts.com?

@nicellenburg
Copy link
Author

freetts.com?

Text to Speech website, free for commercial

@LlemonDuck
Copy link
Contributor

Do you have a link to their license terms? I wasn't able to find it

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@nicellenburg
Copy link
Author

Do you have a link to their license terms? I wasn't able to find it

I couldn't find it either, my friend said they had used it a few times. I emailed them yesterday asking if they could send anything over but haven't received a response yet.

If I don't hear from them before I get off the PC today, I'll just record the audio myself and swap out the wav files :)

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicellenburg @iProdigy @LlemonDuck