Skip to content

Create Glassman #7943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Create Glassman #7943

wants to merge 5 commits into from

Conversation

Mattb2291
Copy link

A plugin which replicates the 'Nightmare Mode' or '1hp' mode.

Simple and functional, this plugin will simulate life with only 1 hitpoint - damage taken from any source will cause the gamemode to finish and return the account to normal.

Glassman mode

@runelite-github-app
Copy link

runelite-github-app bot commented May 3, 2025

@LlemonDuck
Copy link
Contributor

LlemonDuck commented May 7, 2025

use "/" + spriteOverride.getSpriteID() + ".png" https://github.com/Mattb2291/Glassman/blob/852a2ab36ecc417ed082c5a0530548bf9eab24c1/src/main/java/com/Glassman/GlassmanPlugin.java#L222

make sure you clean up your sprite overrides when the plugin shuts down as well

remove your config class so that you don't create a settings icon beside the plugin name with no options

neat, and cute glass hp icon!

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 7, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 8, 2025
@Mattb2291
Copy link
Author

Mattb2291 commented May 8, 2025

Apologies, I changed the commit hash after making the changes and a few better bits of code (not sure if changing the hash was the right way to do it or not...)

@LlemonDuck
Copy link
Contributor

changing the hash is correct, but also you'll need to use a lowercase g in your manifest file name (the one in this repo), so glassman instead of Glassman

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 11, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 11, 2025
@pajlada
Copy link
Contributor

pajlada commented May 11, 2025

Still need to lowercase the plugin manifest file, which is the file you're pushing changes to in this repo (runelite/plugin-hub)
image

@pajlada pajlada added the waiting for author waiting for the pr author to make changes or respond to questions label May 11, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 12, 2025
@Mattb2291
Copy link
Author

Mattb2291 commented May 12, 2025

Still need to lowercase the plugin manifest file, which is the file you're pushing changes to in this repo

Thank you :) I changed all the others to lowercase but didn't see that one (sorry!)

@pajlada
Copy link
Contributor

pajlada commented May 12, 2025

Your plugin fails to build, see the error at https://github.com/runelite/plugin-hub/actions/runs/14981524544/job/42091074308?pr=7943

you'll need to update the plugins field in your runelite-plugin.properties file in your plugin repo to correctly point at the plugin class itself (so com.glassman.GlassmanPlugin if I looked correctly), then update the hash in this PR again

@pajlada pajlada added the waiting for author waiting for the pr author to make changes or respond to questions label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants