-
Notifications
You must be signed in to change notification settings - Fork 12
Fix permissions on keccak.md
#785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Btw, is it possible the root of the issue is that these files have not been checked in to source control with the right permission? |
@tothtamas28 it would probably help, but these files are part of the kompilation artifacts usually placed in the |
Co-authored-by: Tamás Tóth <[email protected]>
Co-authored-by: Tamás Tóth <[email protected]>
What I'm wondering, if the template of these files (i.e. in the |
Ah, got it, thanks, it looks like they don't. If
If we run
In short, it seems that the |
Makes sense, thank you for debugging this. The Nix store in general is read only, so your fix is indeed the right thing to do. |
@tothtamas28 thanks for your help! |
Fixes an issue introduced in #779 by making
out/kompiled/requires/keccak.md
(and any other filed copied torequires
in future) writeable for the current user, group, and others (anyone with access to the file).The files have to writeable so they can be deleted and replaced when
kontrol build --rekompile
is executed. The files not copied fromkontrol/kdist
had write access previously, but the ones we are now copying fromkdist
(such askeccak.md
) don't, which causes issues such as this one: