Improvements to printing using new infrastructure #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
approved these changes
May 21, 2025
Comment on lines
+234
to
+240
| display_args.add_argument( | ||
| '--no-omit-current-body', | ||
| dest='omit_current_body', | ||
| default=True, | ||
| action='store_false', | ||
| help='Display the <currentBody> cell completely.', | ||
| ) |
There was a problem hiding this comment.
Maybe we can modify this (in a later PR) to carry a list of omitted field names (default [ currentBody ], can be emptied for full printing or any field can be added). The use site in __main__ would just pass the list (with angle-brackets added) to CTermShow.
No need to do this now, though.
There was a problem hiding this comment.
It could be possible, but making it a list wouldn't be the way. Using the CTermShow.let(...) method would be the way, which makes it so instances of CTermShow are immutable. But it would be nice to be able to dynamically control which cells are omitted...
jberthold
reviewed
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some improvements to printing that we can implement now that we have merged changes upstream runtimeverification/k#4808.
DisplayOptsto theKMIRAPRNodePrinter, because why not?<currentBody>cell by default in TUI and shower, but enables turning it back on with--no-omit-current-bodyoption to both.SMIRInfoin theproof_dirwhen we have it available inprove-rs, so that it can be used for printing sourcemap information in the show/view commands (like current function name and span).