Skip to content

feat: add array support when no_std enabled #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

ball-hayden
Copy link
Contributor

Adds support for array parsing in a no_std environment.

Not sure if there's a sensible way of adding tests for this, given the tests run in a std environment?

@chifflier
Copy link
Collaborator

Adds support for array parsing in a no_std environment.

Thank you!

Not sure if there's a sensible way of adding tests for this, given the tests run in a std environment?

Good question. There are 2 kinds of tests used:

  • regular unit tests (which honor no_std, but are not good to test things like derive macros
  • compilation tests (based on trybuild). Not sure about that, but I think trybuild just pass the feature flags, at least it worked in a simple test here.

So, to complete no_std support, I think we just have to make cargo test --no-default-features work (it currently fails here). Please open a new issue if you intend to work on it (else I will as soon as I get some free time).

@chifflier chifflier merged commit ed82ded into rust-bakery:master Apr 28, 2025
13 checks passed
@chifflier chifflier mentioned this pull request Apr 29, 2025
@chifflier
Copy link
Collaborator

Note: tests for no_std are now fixed and merged in master

@ball-hayden
Copy link
Contributor Author

Awesome. Thanks @chifflier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants