-
Notifications
You must be signed in to change notification settings - Fork 835
A few doc improvments to /docs
and others
#1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,9 +115,9 @@ println!( | |
); | ||
``` | ||
|
||
### getting more information: nom::error::VerboseError | ||
### getting more information: nom-language::error::VerboseError | ||
|
||
The `VerboseError<I>` type accumulates more information about the chain of | ||
The `VerboseError<I>` type (available from the companion `nom-language` crate) accumulates more information about the chain of | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for making this PR, I've come here after trying to use the VerboseError from nom :) Just a minor suggestion: that the struct comes from a different crate is an important piece of information, I'd not put it in a parenthetical. Maybe something like this instead: The companion |
||
parsers that encountered an error: | ||
|
||
```rust | ||
|
@@ -187,7 +187,7 @@ println!("parsed verbose: {:#?}", json::<VerboseError<&str>>(data)); | |
``` | ||
|
||
But by looking at the original input and the chain of errors, we can build | ||
a more user friendly error message. The `nom::error::convert_error` function | ||
a more user friendly error message. The `nom-language::error::convert_error` function | ||
can build such a message. | ||
|
||
```rust | ||
|
@@ -232,7 +232,7 @@ information, like line and column. | |
|
||
#### nom-supreme | ||
|
||
[nom-supreme](https://docs.rs/nom-supreme) provides the `ErrorTree<I>` error | ||
[nom-supreme](https://docs.rs/nom-supreme) (not updated yet for `nom8`) provides the `ErrorTree<I>` error | ||
type, that provides the same chain of parser errors as `VerboseError`, but also | ||
accumulates errors from the various branches tried by `alt`. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove the doc link here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the thought was that the
tuple
combinator (which is linked to) is deprecated and the examples would just use tuples immediately