-
Notifications
You must be signed in to change notification settings - Fork 211
fix: make dependabot commit message follow conventional commits #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for conventional commits, see: https://www.conventionalcommits.org/en/v1.0.0/ for a good cheat sheet, see: https://kapeli.com/cheat_sheets/Conventional_Commits.docset/Contents/Resources/Documents/index
Also, I filed an issue with the current CI Coverage step failure, as the error message requested this (and suggested this is some compiler-internal bug). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release Please considers deps
a 'releasable unit', but not chore
(docs). I think it'd therefore be nicer to prefix with deps
so that Release Please includes dependency updates in the release / changelog, like here for example. What do you think?
Yes, that makes perfect sense. I just looked for what matched our case closest in the conventional commits cheat sheet, but didn't check on release please. Many thanks for this suggestion, I'll amend both PRs accordingly. |
Feel free to merge both, once the tests pass. I think it is currently OK to ignore the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update and your code comment will definitely be helpful for anyone curious about the prefix.
for conventional commits, see:
https://www.conventionalcommits.org/en/v1.0.0/
for a good cheat sheet, see:
https://kapeli.com/cheat_sheets/Conventional_Commits.docset/Contents/Resources/Documents/index