Implement encryptwallet method and test #250
Open
+103
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use node wallet for v20_and_below
GideonBature
force-pushed
the
encryptwallet
branch
from
f473e1e to
e9bf939
Compare
|
Nice, you're on a roll. |
Thank you! |
tcharding
reviewed
Jun 17, 2025
Comment on lines
+164
to
+171
| let client = match () { | ||
| #[cfg(feature = "v20_and_below")] | ||
| () => node.create_wallet(wallet_name).expect("createwallet"), | ||
| #[cfg(not(feature = "v20_and_below"))] | ||
| () => { | ||
| node.client.create_wallet(wallet_name).expect("createwallet"); | ||
| &node.client | ||
| }, |
There was a problem hiding this comment.
Are you feeling adventurous? It would be nice to investigate why this is needed and move the feature gating logic to node/src/lib.rs in the create_wallet function so that every test author does not have to think about it. FTR I did not investigate, I vaguely remember hitting this before though so my suggestion is just a hunch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC method
encryptwalletdoes return a type. We want to test this to catch any changes in behavior in future Core versions.This PR adds a client function that errors if the return value is anything other than the type it returns, along with an integration test that calls this function.
Ref: #116