Lint non-workspace crates in CI #268
Open
+42
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed the versions when adding support for v29 but did not fix this doc.
`verify` is intentionally not part of the workspace. Add a script to lint it.
|
If/when this merges we should run the formatter as well. And also investigate #246 |
justfile
Outdated
| @@ -18,6 +21,14 @@ check: | |||
| # Lint everything. | |||
| lint: | |||
There was a problem hiding this comment.
Suggested change
| lint: | |
| lint: lint-verify lint-integration-tests |
The other tests need to be listed as dependencies. It doesn't run as it currently is and I had to look up why: If you list them below it's run in the shell so would need to be just lint-verify.
|
Looking at this now, I clearly see the mistakes I made earlier and I really appreciate how clean and well structured your commits are it's a great reference for improving mine. |
Add commands and alias' to lint `verify` and `intergration-tests`.
Use `matches!` instead of matching manually. Found by clippy.
Simplify and put the positive bool first and the negative second. E.g `if this && !that` Because it reads a bit easier. Internal change only, no logic change. Clears a clippy warning.
Lint the `verify` and `integration_tests` crates in CI using the scripts we already have.
tcharding
force-pushed
the
06-24-ci-lint-non-workspace-crates
branch
from
dd5ea03 to
2858e46
Compare
|
Thanks @0xZaddyy, glad you found it useful. Stick at it man, its a long path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a bunch of preparation and then add commands to the already present lint job in CI to lint
verifyandintegration_tests.Close: #236