Backport of #809: fix crash in Descriptor::parse_desc
#810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a descriptor with `Descriptor::parse_descriptor`, we first parse as a string and then parse the keys. We fail to consider parsing errors in the keys, resulting in a panic. Also, clean up the panic message so it's clearer what's going on.
|
Also present in 11.x and 10.x. 9.x and before are unaffected. I think I should do the two other backports, though I'll wait for an ACK on the main PR first. |
|
cc @sanket1729 can you review this? It may be easier to just read it independently of #810 since it's a smaller change to avoid any API changes. |
apoelstra
force-pushed
the
2025-04--backport-809
branch
from
b83e787 to
212d78a
Compare
|
Oops, I forgot to update the lockfiles on this one. |
|
Tagged and published. I will do the other backports today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #809 and does another patch release.