-
Notifications
You must be signed in to change notification settings - Fork 286
Add a feature to disable replacing C symbols with rust #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…with rust. isn't compatible with no-std
Can you put a |
Done. took the liberty and added that warning to |
767123b
to
fe8ac1e
Compare
ACK. This 176 appears to fully solve my issues linking into Core with its libsecp. |
I like the comment. Matt's ACK is good enough for me. |
@elichai @TheBlueMatt so are you saying that you are using the C symbols exported by rust-secp? I don't think that's what this crate is supposed for, is it? Doing that would also stop working with #169, which arguably makes this crate more interoperable with other systems. |
Oh I think I understood it wrong. You're using this library with the libsecp symbols already exported in Core? That already makes more sense to me, but I think that will still be hard to make work with #169. |
Right, for #169 we’ll need a feature to skip the -sys dependency and not use version-tagged symbols.
… On Oct 29, 2019, at 02:46, Steven Roose ***@***.***> wrote:
Oh I think I understood it wrong. You're using this library with the libsecp symbols already exported in Core?
That already makes more sense to me, but I think that will still be hard to make work with #169.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hi,
Requested in IRC by @TheBlueMatt the main use case is bitcoin core integration.
such that you can use upstream's libsecp256k1 with this library.
this feature is not compatible with
no-std
.