Clean dependencies, fix cross compilation, fix runtime cargo-manifest bug, change from failure to std::error #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
requested changes
Dec 22, 2019
TheLostLambda
force-pushed
the
master
branch
from
c0f64fd to
7f92929
Compare
|
Sorry for the messy commit, I got a bit carried away and forgot to split it up. That should be a nicer history now! |
matthiasbeyer
approved these changes
Dec 22, 2019
|
Okay, sounds good. I'm using this fork in the meantime. I'll let you know if I encounter any issues, but it's working well on macOS Catelina, Windows 10, Arch Linux, and Linux Mint so far. |
|
Looks good to me. I don't see any red flags while going through the code so merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a few typos in the examples.
Overall, this fixes #23, #24, and bumps the library to use new versions of all of it's dependencies.
It now works outside of cargo directories (binaries produced before this fix would crash at runtime if executed outside of a project directory — essentially rendering the library unusable). My solution was to just use an empty organization string, if someone has a better suggestion, please let me know, but the cargo-manifest solution from before was a lot of code that duplicated the user-provided string and broke at runtime.
This also cross-compiles to macOS and the number of dependencies pulled in by this library was cut in third.